commit fbc861320fa3f5f248aa34728b6f09f57ffa395f
author Faris Ansari <netchampfaris@users.noreply.github.com> Wed Jun 26 13:31:31 2019 +0530
committer Nabin Hait <nabinhait@gmail.com> Wed Jun 26 13:31:31 2019 +0530
tree 906b9f7620fd8736f4a5fd1f030ece8a2f21005e
parent 8c621ab90c13d073b2a6072bc12d33a56fefc8c0

fix: Don't append None values in against_account (#18031)

erpnext/accounts/doctype/sales_invoice/sales_invoice.py

diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
index 503f4f4..e166fa2 100644
--- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
+++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
@@ -485,7 +485,7 @@
 		"""Set against account for debit to account"""
 		against_acc = []
 		for d in self.get('items'):
-			if d.income_account not in against_acc:
+			if d.income_account and d.income_account not in against_acc:
 				against_acc.append(d.income_account)
 		self.against_income_account = ','.join(against_acc)