Improve typing and delete an unnecessary file
diff --git a/src/utils/getCommandDataByName.ts b/src/utils/getCommandDataByName.ts
index 46f4362..70a2af6 100644
--- a/src/utils/getCommandDataByName.ts
+++ b/src/utils/getCommandDataByName.ts
@@ -1,22 +1,40 @@
import type Discord from "discord.js";
import client from "./client.js";
+/**
+* @param name The name of the command, not including a leading slash. This can be space or slash separated e.g. "mod/about" or "mod about"
+* @returns A string which when put into Discord will mention the command if the command exists or a codeblock with the command name if it does not
+*
+* @throws Will throw an error if as empty string is passed
+**/
export const getCommandMentionByName = (name: string): string => {
const split = name.replaceAll("/", " ").split(" ");
- const commandName: string = split[0]!;
+ const commandName: string | undefined = split[0];
+ if (commandName === undefined) throw new RangeError(`Invalid command ${name} provided to getCommandByName`);
const filterCommand = (command: Discord.ApplicationCommand) => command.name === commandName;
const command = client.fetchedCommands.filter((c) => filterCommand(c));
- if (command.size === 0) return `\`/${name.replaceAll("/", " ")}\``;
- const commandID = command.first()!.id;
+ const commandID = command.first()?.id;
+
+ if (commandID === undefined) return `\`/${name.replaceAll("/", " ")}\``;
+
return `</${split.join(" ")}:${commandID}>`;
};
+/**
+* @param name The name of the command, not including a leading slash. This can be space or slash separated e.g. "mod/about" or "mod about"
+* @returns An object containing the command name, the command description and a string which when put into Discord will mention the command
+*
+* @throws Will throw an error if the command doesn't exist
+* @throws Will throw an error if as empty string is passed
+**/
export const getCommandByName = (name: string): { name: string; description: string; mention: string } => {
const split = name.replaceAll(" ", "/");
- const command = client.commands["commands/" + split]!;
- // console.log(command)
+ const command = client.commands["commands/" + split];
+
+ if (command === undefined) throw new RangeError(`Invalid command ${name} provided to getCommandByName`);
+
const mention = getCommandMentionByName(name);
return {
name: command[1].name,