Anand Doshi | 885e074 | 2015-03-03 14:55:30 +0530 | [diff] [blame] | 1 | # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors |
Rushabh Mehta | e67d1fb | 2013-08-05 14:59:54 +0530 | [diff] [blame] | 2 | # License: GNU General Public License v3. See license.txt |
Nabin Hait | c3afb25 | 2013-03-19 12:01:24 +0530 | [diff] [blame] | 3 | |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 4 | import json |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 5 | from collections import defaultdict |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 6 | |
| 7 | import frappe |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 8 | from frappe import _ |
| 9 | from frappe.utils import cint, cstr, flt, get_link_to_form, getdate |
| 10 | |
| 11 | import erpnext |
Chillar Anand | 915b343 | 2021-09-02 16:44:59 +0530 | [diff] [blame] | 12 | from erpnext.accounts.general_ledger import ( |
| 13 | make_gl_entries, |
| 14 | make_reverse_gl_entries, |
| 15 | process_gl_map, |
| 16 | ) |
Rohit Waghchaure | 5d5dc56 | 2021-06-22 15:23:04 +0530 | [diff] [blame] | 17 | from erpnext.accounts.utils import get_fiscal_year |
Rushabh Mehta | 1f84799 | 2013-12-12 19:12:19 +0530 | [diff] [blame] | 18 | from erpnext.controllers.accounts_controller import AccountsController |
Nabin Hait | 6d7b0ce | 2017-06-15 11:09:27 +0530 | [diff] [blame] | 19 | from erpnext.stock import get_warehouse_account_map |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 20 | from erpnext.stock.stock_ledger import get_valuation_rate |
| 21 | |
Nabin Hait | c3afb25 | 2013-03-19 12:01:24 +0530 | [diff] [blame] | 22 | |
Nabin Hait | 5a9579b | 2018-12-24 14:54:42 +0530 | [diff] [blame] | 23 | class QualityInspectionRequiredError(frappe.ValidationError): pass |
| 24 | class QualityInspectionRejectedError(frappe.ValidationError): pass |
Anurag Mishra | 0c8411d | 2018-12-28 16:53:00 +0530 | [diff] [blame] | 25 | class QualityInspectionNotSubmittedError(frappe.ValidationError): pass |
Nabin Hait | 5a9579b | 2018-12-24 14:54:42 +0530 | [diff] [blame] | 26 | |
Nabin Hait | c3afb25 | 2013-03-19 12:01:24 +0530 | [diff] [blame] | 27 | class StockController(AccountsController): |
Nabin Hait | 8af429d | 2016-11-16 17:21:59 +0530 | [diff] [blame] | 28 | def validate(self): |
| 29 | super(StockController, self).validate() |
Marica | fd3d976 | 2020-06-12 12:30:59 +0530 | [diff] [blame] | 30 | if not self.get('is_return'): |
marination | 596560c | 2020-06-11 16:39:03 +0530 | [diff] [blame] | 31 | self.validate_inspection() |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 32 | self.validate_serialized_batch() |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 33 | self.clean_serial_nos() |
marination | fd04e96 | 2020-04-03 15:46:48 +0530 | [diff] [blame] | 34 | self.validate_customer_provided_item() |
Anupam Kumar | 7e1dcf9 | 2021-02-11 20:19:30 +0530 | [diff] [blame] | 35 | self.set_rate_of_stock_uom() |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 36 | self.validate_internal_transfer() |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 37 | self.validate_putaway_capacity() |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 38 | |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 39 | def make_gl_entries(self, gl_entries=None, from_repost=False): |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 40 | if self.docstatus == 2: |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 41 | make_reverse_gl_entries(voucher_type=self.doctype, voucher_no=self.name) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 42 | |
Rohit Waghchaure | e9ff191 | 2017-06-19 12:54:59 +0530 | [diff] [blame] | 43 | if cint(erpnext.is_perpetual_inventory_enabled(self.company)): |
Rohit Waghchaure | 6b33c9b | 2019-03-08 11:13:35 +0530 | [diff] [blame] | 44 | warehouse_account = get_warehouse_account_map(self.company) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 45 | |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 46 | if self.docstatus==1: |
Nabin Hait | 9784d27 | 2016-12-30 16:21:35 +0530 | [diff] [blame] | 47 | if not gl_entries: |
| 48 | gl_entries = self.get_gl_entries(warehouse_account) |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 49 | make_gl_entries(gl_entries, from_repost=from_repost) |
Nabin Hait | 145e5e2 | 2013-10-22 23:51:41 +0530 | [diff] [blame] | 50 | |
Rohit Waghchaure | b6381c6 | 2018-06-12 13:54:40 +0530 | [diff] [blame] | 51 | elif self.doctype in ['Purchase Receipt', 'Purchase Invoice'] and self.docstatus == 1: |
Rohit Waghchaure | 4216972 | 2018-05-16 18:16:08 +0530 | [diff] [blame] | 52 | gl_entries = [] |
| 53 | gl_entries = self.get_asset_gl_entry(gl_entries) |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 54 | make_gl_entries(gl_entries, from_repost=from_repost) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 55 | |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 56 | def validate_serialized_batch(self): |
| 57 | from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos |
| 58 | for d in self.get("items"): |
| 59 | if hasattr(d, 'serial_no') and hasattr(d, 'batch_no') and d.serial_no and d.batch_no: |
Rohit Waghchaure | 6b482eb | 2021-07-23 16:40:45 +0530 | [diff] [blame] | 60 | serial_nos = frappe.get_all("Serial No", |
| 61 | fields=["batch_no", "name", "warehouse"], |
| 62 | filters={ |
| 63 | "name": ("in", get_serial_nos(d.serial_no)) |
| 64 | } |
| 65 | ) |
| 66 | |
| 67 | for row in serial_nos: |
| 68 | if row.warehouse and row.batch_no != d.batch_no: |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 69 | frappe.throw(_("Row #{0}: Serial No {1} does not belong to Batch {2}") |
Rohit Waghchaure | 6b482eb | 2021-07-23 16:40:45 +0530 | [diff] [blame] | 70 | .format(d.idx, row.name, d.batch_no)) |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 71 | |
Saqib Ansari | 903055b | 2020-10-20 11:59:06 +0530 | [diff] [blame] | 72 | if flt(d.qty) > 0.0 and d.get("batch_no") and self.get("posting_date") and self.docstatus < 2: |
rohitwaghchaure | 28a4880 | 2020-04-28 13:01:43 +0530 | [diff] [blame] | 73 | expiry_date = frappe.get_cached_value("Batch", d.get("batch_no"), "expiry_date") |
| 74 | |
| 75 | if expiry_date and getdate(expiry_date) < getdate(self.posting_date): |
| 76 | frappe.throw(_("Row #{0}: The batch {1} has already expired.") |
| 77 | .format(d.idx, get_link_to_form("Batch", d.get("batch_no")))) |
| 78 | |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 79 | def clean_serial_nos(self): |
| 80 | for row in self.get("items"): |
| 81 | if hasattr(row, "serial_no") and row.serial_no: |
marination | 41035b0 | 2021-10-14 18:29:46 +0530 | [diff] [blame] | 82 | # replace commas by linefeed |
| 83 | row.serial_no = row.serial_no.replace(",", "\n") |
| 84 | |
| 85 | # strip preceeding and succeeding spaces for each SN |
| 86 | # (SN could have valid spaces in between e.g. SN - 123 - 2021) |
| 87 | serial_no_list = row.serial_no.split("\n") |
Marica | 8cf188d | 2021-10-14 19:21:41 +0530 | [diff] [blame] | 88 | serial_no_list = [sn.strip() for sn in serial_no_list] |
marination | 41035b0 | 2021-10-14 18:29:46 +0530 | [diff] [blame] | 89 | |
| 90 | row.serial_no = "\n".join(serial_no_list) |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 91 | |
Nabin Hait | e83069c | 2013-11-14 18:40:08 +0530 | [diff] [blame] | 92 | def get_gl_entries(self, warehouse_account=None, default_expense_account=None, |
Nabin Hait | 142007a | 2013-09-17 15:15:16 +0530 | [diff] [blame] | 93 | default_cost_center=None): |
Nabin Hait | adeb976 | 2014-10-06 11:53:52 +0530 | [diff] [blame] | 94 | |
Nabin Hait | 142007a | 2013-09-17 15:15:16 +0530 | [diff] [blame] | 95 | if not warehouse_account: |
Rohit Waghchaure | 6b33c9b | 2019-03-08 11:13:35 +0530 | [diff] [blame] | 96 | warehouse_account = get_warehouse_account_map(self.company) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 97 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 98 | sle_map = self.get_stock_ledger_details() |
| 99 | voucher_details = self.get_voucher_details(default_expense_account, default_cost_center, sle_map) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 100 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 101 | gl_list = [] |
Nabin Hait | 7a75e10 | 2013-09-17 10:21:20 +0530 | [diff] [blame] | 102 | warehouse_with_no_account = [] |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 103 | precision = self.get_debit_field_precision() |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 104 | for item_row in voucher_details: |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 105 | |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 106 | sle_list = sle_map.get(item_row.name) |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 107 | if sle_list: |
| 108 | for sle in sle_list: |
| 109 | if warehouse_account.get(sle.warehouse): |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 110 | # from warehouse account |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 111 | |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 112 | self.check_expense_account(item_row) |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 113 | |
Javier Wong | 9b11d9b | 2017-04-14 18:24:04 +0800 | [diff] [blame] | 114 | # If the item does not have the allow zero valuation rate flag set |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 115 | # and ( valuation rate not mentioned in an incoming entry |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 116 | # or incoming entry not found while delivering the item), |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 117 | # try to pick valuation rate from previous sle or Item master and update in SLE |
| 118 | # Otherwise, throw an exception |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 119 | |
| 120 | if not sle.stock_value_difference and self.doctype != "Stock Reconciliation" \ |
Javier Wong | 9b11d9b | 2017-04-14 18:24:04 +0800 | [diff] [blame] | 121 | and not item_row.get("allow_zero_valuation_rate"): |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 122 | |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 123 | sle = self.update_stock_ledger_entries(sle) |
Rushabh Mehta | 14a908b | 2015-10-15 12:28:20 +0530 | [diff] [blame] | 124 | |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 125 | # expense account/ target_warehouse / source_warehouse |
| 126 | if item_row.get('target_warehouse'): |
| 127 | warehouse = item_row.get('target_warehouse') |
| 128 | expense_account = warehouse_account[warehouse]["account"] |
| 129 | else: |
| 130 | expense_account = item_row.expense_account |
| 131 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 132 | gl_list.append(self.get_gl_dict({ |
Nabin Hait | 6d7b0ce | 2017-06-15 11:09:27 +0530 | [diff] [blame] | 133 | "account": warehouse_account[sle.warehouse]["account"], |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 134 | "against": expense_account, |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 135 | "cost_center": item_row.cost_center, |
Deepesh Garg | 1b30ca6 | 2020-06-19 12:12:08 +0530 | [diff] [blame] | 136 | "project": item_row.project or self.get('project'), |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 137 | "remarks": self.get("remarks") or "Accounting Entry for Stock", |
rohitwaghchaure | 61ad629 | 2020-01-15 16:35:31 +0530 | [diff] [blame] | 138 | "debit": flt(sle.stock_value_difference, precision), |
Nabin Hait | 8770ea2 | 2019-05-22 18:03:09 +0530 | [diff] [blame] | 139 | "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No", |
deepeshgarg007 | 3d11ac0 | 2019-05-19 00:02:01 +0530 | [diff] [blame] | 140 | }, warehouse_account[sle.warehouse]["account_currency"], item=item_row)) |
Nabin Hait | 27994c2 | 2013-08-26 16:53:30 +0530 | [diff] [blame] | 141 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 142 | gl_list.append(self.get_gl_dict({ |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 143 | "account": expense_account, |
Nabin Hait | 6d7b0ce | 2017-06-15 11:09:27 +0530 | [diff] [blame] | 144 | "against": warehouse_account[sle.warehouse]["account"], |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 145 | "cost_center": item_row.cost_center, |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 146 | "remarks": self.get("remarks") or "Accounting Entry for Stock", |
rohitwaghchaure | 61ad629 | 2020-01-15 16:35:31 +0530 | [diff] [blame] | 147 | "credit": flt(sle.stock_value_difference, precision), |
Nabin Hait | 3f119ec | 2019-05-16 17:28:39 +0530 | [diff] [blame] | 148 | "project": item_row.get("project") or self.get("project"), |
Nabin Hait | 8770ea2 | 2019-05-22 18:03:09 +0530 | [diff] [blame] | 149 | "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No" |
deepeshgarg007 | 3d11ac0 | 2019-05-19 00:02:01 +0530 | [diff] [blame] | 150 | }, item=item_row)) |
Nabin Hait | 7a75e10 | 2013-09-17 10:21:20 +0530 | [diff] [blame] | 151 | elif sle.warehouse not in warehouse_with_no_account: |
| 152 | warehouse_with_no_account.append(sle.warehouse) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 153 | |
| 154 | if warehouse_with_no_account: |
Nabin Hait | d662502 | 2016-10-24 18:17:57 +0530 | [diff] [blame] | 155 | for wh in warehouse_with_no_account: |
| 156 | if frappe.db.get_value("Warehouse", wh, "company"): |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 157 | frappe.throw(_("Warehouse {0} is not linked to any account, please mention the account in the warehouse record or set default inventory account in company {1}.").format(wh, self.company)) |
Rushabh Mehta | 14a908b | 2015-10-15 12:28:20 +0530 | [diff] [blame] | 158 | |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 159 | return process_gl_map(gl_list, precision=precision) |
| 160 | |
| 161 | def get_debit_field_precision(self): |
| 162 | if not frappe.flags.debit_field_precision: |
| 163 | frappe.flags.debit_field_precision = frappe.get_precision("GL Entry", "debit_in_account_currency") |
| 164 | |
| 165 | return frappe.flags.debit_field_precision |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 166 | |
Rohit Waghchaure | 3899d74 | 2017-01-25 18:47:53 +0530 | [diff] [blame] | 167 | def update_stock_ledger_entries(self, sle): |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 168 | sle.valuation_rate = get_valuation_rate(sle.item_code, sle.warehouse, |
Rohit Waghchaure | a5f4094 | 2017-06-16 15:21:36 +0530 | [diff] [blame] | 169 | self.doctype, self.name, currency=self.company_currency, company=self.company) |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 170 | |
Nabin Hait | cb19f52 | 2017-01-25 19:20:35 +0530 | [diff] [blame] | 171 | sle.stock_value = flt(sle.qty_after_transaction) * flt(sle.valuation_rate) |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 172 | sle.stock_value_difference = flt(sle.actual_qty) * flt(sle.valuation_rate) |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 173 | |
Kanchan Chauhan | b77eaf7 | 2017-01-28 13:18:49 +0530 | [diff] [blame] | 174 | if sle.name: |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 175 | frappe.db.sql(""" |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 176 | update |
| 177 | `tabStock Ledger Entry` |
| 178 | set |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 179 | stock_value = %(stock_value)s, |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 180 | valuation_rate = %(valuation_rate)s, |
| 181 | stock_value_difference = %(stock_value_difference)s |
| 182 | where |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 183 | name = %(name)s""", (sle)) |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 184 | |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 185 | return sle |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 186 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 187 | def get_voucher_details(self, default_expense_account, default_cost_center, sle_map): |
| 188 | if self.doctype == "Stock Reconciliation": |
Nabin Hait | 3f119ec | 2019-05-16 17:28:39 +0530 | [diff] [blame] | 189 | reconciliation_purpose = frappe.db.get_value(self.doctype, self.name, "purpose") |
| 190 | is_opening = "Yes" if reconciliation_purpose == "Opening Stock" else "No" |
| 191 | details = [] |
Nabin Hait | 34c551d | 2019-07-03 10:34:31 +0530 | [diff] [blame] | 192 | for voucher_detail_no in sle_map: |
Nabin Hait | 3f119ec | 2019-05-16 17:28:39 +0530 | [diff] [blame] | 193 | details.append(frappe._dict({ |
| 194 | "name": voucher_detail_no, |
| 195 | "expense_account": default_expense_account, |
| 196 | "cost_center": default_cost_center, |
| 197 | "is_opening": is_opening |
| 198 | })) |
| 199 | return details |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 200 | else: |
Nabin Hait | dd38a26 | 2014-12-26 13:15:21 +0530 | [diff] [blame] | 201 | details = self.get("items") |
Anand Doshi | 094610d | 2014-04-16 19:56:53 +0530 | [diff] [blame] | 202 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 203 | if default_expense_account or default_cost_center: |
| 204 | for d in details: |
| 205 | if default_expense_account and not d.get("expense_account"): |
| 206 | d.expense_account = default_expense_account |
| 207 | if default_cost_center and not d.get("cost_center"): |
| 208 | d.cost_center = default_cost_center |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 209 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 210 | return details |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 211 | |
Nabin Hait | b9e0481 | 2014-09-26 14:22:18 +0530 | [diff] [blame] | 212 | def get_items_and_warehouses(self): |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 213 | items, warehouses = [], [] |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 214 | |
Nabin Hait | dd38a26 | 2014-12-26 13:15:21 +0530 | [diff] [blame] | 215 | if hasattr(self, "items"): |
| 216 | item_doclist = self.get("items") |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 217 | elif self.doctype == "Stock Reconciliation": |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 218 | item_doclist = [] |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 219 | data = json.loads(self.reconciliation_json) |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 220 | for row in data[data.index(self.head_row)+1:]: |
| 221 | d = frappe._dict(zip(["item_code", "warehouse", "qty", "valuation_rate"], row)) |
| 222 | item_doclist.append(d) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 223 | |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 224 | if item_doclist: |
| 225 | for d in item_doclist: |
| 226 | if d.item_code and d.item_code not in items: |
| 227 | items.append(d.item_code) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 228 | |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 229 | if d.get("warehouse") and d.warehouse not in warehouses: |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 230 | warehouses.append(d.warehouse) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 231 | |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 232 | if self.doctype == "Stock Entry": |
| 233 | if d.get("s_warehouse") and d.s_warehouse not in warehouses: |
| 234 | warehouses.append(d.s_warehouse) |
| 235 | if d.get("t_warehouse") and d.t_warehouse not in warehouses: |
| 236 | warehouses.append(d.t_warehouse) |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 237 | |
Nabin Hait | b9e0481 | 2014-09-26 14:22:18 +0530 | [diff] [blame] | 238 | return items, warehouses |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 239 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 240 | def get_stock_ledger_details(self): |
| 241 | stock_ledger = {} |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 242 | stock_ledger_entries = frappe.db.sql(""" |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 243 | select |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 244 | name, warehouse, stock_value_difference, valuation_rate, |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 245 | voucher_detail_no, item_code, posting_date, posting_time, |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 246 | actual_qty, qty_after_transaction |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 247 | from |
| 248 | `tabStock Ledger Entry` |
| 249 | where |
| 250 | voucher_type=%s and voucher_no=%s |
| 251 | """, (self.doctype, self.name), as_dict=True) |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 252 | |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 253 | for sle in stock_ledger_entries: |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 254 | stock_ledger.setdefault(sle.voucher_detail_no, []).append(sle) |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 255 | return stock_ledger |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 256 | |
Rushabh Mehta | 551406a | 2017-04-21 12:40:19 +0530 | [diff] [blame] | 257 | def make_batches(self, warehouse_field): |
Rushabh Mehta | e385b5b | 2017-04-20 15:21:01 +0530 | [diff] [blame] | 258 | '''Create batches if required. Called before submit''' |
| 259 | for d in self.items: |
Rushabh Mehta | 551406a | 2017-04-21 12:40:19 +0530 | [diff] [blame] | 260 | if d.get(warehouse_field) and not d.batch_no: |
| 261 | has_batch_no, create_new_batch = frappe.db.get_value('Item', d.item_code, ['has_batch_no', 'create_new_batch']) |
| 262 | if has_batch_no and create_new_batch: |
| 263 | d.batch_no = frappe.get_doc(dict( |
| 264 | doctype='Batch', |
| 265 | item=d.item_code, |
| 266 | supplier=getattr(self, 'supplier', None), |
| 267 | reference_doctype=self.doctype, |
| 268 | reference_name=self.name)).insert().name |
Rushabh Mehta | e385b5b | 2017-04-20 15:21:01 +0530 | [diff] [blame] | 269 | |
Nabin Hait | 27994c2 | 2013-08-26 16:53:30 +0530 | [diff] [blame] | 270 | def check_expense_account(self, item): |
Rushabh Mehta | 052fe82 | 2014-04-16 19:20:11 +0530 | [diff] [blame] | 271 | if not item.get("expense_account"): |
Rohit Waghchaure | ceab692 | 2020-11-18 17:57:35 +0530 | [diff] [blame] | 272 | msg = _("Please set an Expense Account in the Items table") |
| 273 | frappe.throw(_("Row #{0}: Expense Account not set for the Item {1}. {2}") |
| 274 | .format(item.idx, frappe.bold(item.item_code), msg), title=_("Expense Account Missing")) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 275 | |
Anand Doshi | 496123a | 2014-06-19 19:25:19 +0530 | [diff] [blame] | 276 | else: |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 277 | is_expense_account = frappe.get_cached_value("Account", |
Nabin Hait | 00778c9 | 2014-06-25 19:12:24 +0530 | [diff] [blame] | 278 | item.get("expense_account"), "report_type")=="Profit and Loss" |
jof2jc | 524ebbc | 2016-02-08 23:44:55 +0700 | [diff] [blame] | 279 | if self.doctype not in ("Purchase Receipt", "Purchase Invoice", "Stock Reconciliation", "Stock Entry") and not is_expense_account: |
Nabin Hait | 00778c9 | 2014-06-25 19:12:24 +0530 | [diff] [blame] | 280 | frappe.throw(_("Expense / Difference account ({0}) must be a 'Profit or Loss' account") |
| 281 | .format(item.get("expense_account"))) |
Anand Doshi | 496123a | 2014-06-19 19:25:19 +0530 | [diff] [blame] | 282 | if is_expense_account and not item.get("cost_center"): |
| 283 | frappe.throw(_("{0} {1}: Cost Center is mandatory for Item {2}").format( |
| 284 | _(self.doctype), self.name, item.get("item_code"))) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 285 | |
Rohit Waghchaure | 8996b7d | 2020-01-23 17:36:52 +0530 | [diff] [blame] | 286 | def delete_auto_created_batches(self): |
| 287 | for d in self.items: |
| 288 | if not d.batch_no: continue |
| 289 | |
Rohit Waghchaure | ceab692 | 2020-11-18 17:57:35 +0530 | [diff] [blame] | 290 | serial_nos = [sr.name for sr in frappe.get_all("Serial No", |
| 291 | {'batch_no': d.batch_no, 'status': 'Inactive'})] |
| 292 | |
Saqib | e9ac3e0 | 2020-03-02 15:02:58 +0530 | [diff] [blame] | 293 | if serial_nos: |
| 294 | frappe.db.set_value("Serial No", { 'name': ['in', serial_nos] }, "batch_no", None) |
| 295 | |
Rohit Waghchaure | 8996b7d | 2020-01-23 17:36:52 +0530 | [diff] [blame] | 296 | d.batch_no = None |
| 297 | d.db_set("batch_no", None) |
| 298 | |
| 299 | for data in frappe.get_all("Batch", |
| 300 | {'reference_name': self.name, 'reference_doctype': self.doctype}): |
| 301 | frappe.delete_doc("Batch", data.name) |
Rohit Waghchaure | 4f4dbf1 | 2020-01-23 12:42:42 +0530 | [diff] [blame] | 302 | |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 303 | def get_sl_entries(self, d, args): |
Nabin Hait | 5288bde | 2014-11-03 15:08:21 +0530 | [diff] [blame] | 304 | sl_dict = frappe._dict({ |
Nabin Hait | 296d626 | 2014-05-02 17:36:13 +0530 | [diff] [blame] | 305 | "item_code": d.get("item_code", None), |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 306 | "warehouse": d.get("warehouse", None), |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 307 | "posting_date": self.posting_date, |
| 308 | "posting_time": self.posting_time, |
Valmik Jangla | d89dcf6 | 2016-03-04 14:33:49 +0530 | [diff] [blame] | 309 | 'fiscal_year': get_fiscal_year(self.posting_date, company=self.company)[0], |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 310 | "voucher_type": self.doctype, |
| 311 | "voucher_no": self.name, |
Nabin Hait | 1e2f20a | 2013-08-02 11:42:11 +0530 | [diff] [blame] | 312 | "voucher_detail_no": d.name, |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 313 | "actual_qty": (self.docstatus==1 and 1 or -1)*flt(d.get("stock_qty")), |
Nabin Hait | c865f22 | 2015-09-21 09:18:43 +0530 | [diff] [blame] | 314 | "stock_uom": frappe.db.get_value("Item", args.get("item_code") or d.get("item_code"), "stock_uom"), |
Nabin Hait | 1e2f20a | 2013-08-02 11:42:11 +0530 | [diff] [blame] | 315 | "incoming_rate": 0, |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 316 | "company": self.company, |
Nabin Hait | 296d626 | 2014-05-02 17:36:13 +0530 | [diff] [blame] | 317 | "batch_no": cstr(d.get("batch_no")).strip(), |
| 318 | "serial_no": d.get("serial_no"), |
rohitwaghchaure | 93779c2 | 2018-03-21 17:52:41 +0530 | [diff] [blame] | 319 | "project": d.get("project") or self.get('project'), |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 320 | "is_cancelled": 1 if self.docstatus==2 else 0 |
Nabin Hait | 5288bde | 2014-11-03 15:08:21 +0530 | [diff] [blame] | 321 | }) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 322 | |
Nabin Hait | 1e2f20a | 2013-08-02 11:42:11 +0530 | [diff] [blame] | 323 | sl_dict.update(args) |
| 324 | return sl_dict |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 325 | |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 326 | def make_sl_entries(self, sl_entries, allow_negative_stock=False, |
Nabin Hait | 54c865e | 2015-03-27 15:38:31 +0530 | [diff] [blame] | 327 | via_landed_cost_voucher=False): |
Rushabh Mehta | 1f84799 | 2013-12-12 19:12:19 +0530 | [diff] [blame] | 328 | from erpnext.stock.stock_ledger import make_sl_entries |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 329 | make_sl_entries(sl_entries, allow_negative_stock, via_landed_cost_voucher) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 330 | |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 331 | def make_gl_entries_on_cancel(self): |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 332 | if frappe.db.sql("""select name from `tabGL Entry` where voucher_type=%s |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 333 | and voucher_no=%s""", (self.doctype, self.name)): |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 334 | self.make_gl_entries() |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 335 | |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 336 | def get_serialized_items(self): |
| 337 | serialized_items = [] |
Ankush Menat | a9c84f7 | 2021-06-11 16:00:48 +0530 | [diff] [blame] | 338 | item_codes = list(set(d.item_code for d in self.get("items"))) |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 339 | if item_codes: |
| 340 | serialized_items = frappe.db.sql_list("""select name from `tabItem` |
Rushabh Mehta | 1e8025b | 2015-07-24 15:16:25 +0530 | [diff] [blame] | 341 | where has_serial_no=1 and name in ({})""".format(", ".join(["%s"]*len(item_codes))), |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 342 | tuple(item_codes)) |
| 343 | |
| 344 | return serialized_items |
Rushabh Mehta | b16b9cd | 2015-08-03 16:13:33 +0530 | [diff] [blame] | 345 | |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 346 | def validate_warehouse(self): |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 347 | from erpnext.stock.utils import validate_disabled_warehouse, validate_warehouse_company |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 348 | |
Ankush Menat | a9c84f7 | 2021-06-11 16:00:48 +0530 | [diff] [blame] | 349 | warehouses = list(set(d.warehouse for d in |
| 350 | self.get("items") if getattr(d, "warehouse", None))) |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 351 | |
Deepesh Garg | 15ff6a5 | 2020-02-18 12:28:41 +0530 | [diff] [blame] | 352 | target_warehouses = list(set([d.target_warehouse for d in |
| 353 | self.get("items") if getattr(d, "target_warehouse", None)])) |
| 354 | |
| 355 | warehouses.extend(target_warehouses) |
| 356 | |
| 357 | from_warehouse = list(set([d.from_warehouse for d in |
| 358 | self.get("items") if getattr(d, "from_warehouse", None)])) |
| 359 | |
| 360 | warehouses.extend(from_warehouse) |
| 361 | |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 362 | for w in warehouses: |
Jannat Patel | 30c8873 | 2021-02-11 11:46:48 +0530 | [diff] [blame] | 363 | validate_disabled_warehouse(w) |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 364 | validate_warehouse_company(w, self.company) |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 365 | |
Anand Doshi | 6b71ef5 | 2016-01-06 16:32:06 +0530 | [diff] [blame] | 366 | def update_billing_percentage(self, update_modified=True): |
marination | d6596a1 | 2020-11-02 15:07:48 +0530 | [diff] [blame] | 367 | target_ref_field = "amount" |
| 368 | if self.doctype == "Delivery Note": |
| 369 | target_ref_field = "amount - (returned_qty * rate)" |
| 370 | |
Nabin Hait | bdab0ee | 2015-12-30 19:08:11 +0530 | [diff] [blame] | 371 | self._update_percent_field({ |
| 372 | "target_dt": self.doctype + " Item", |
| 373 | "target_parent_dt": self.doctype, |
| 374 | "target_parent_field": "per_billed", |
marination | d6596a1 | 2020-11-02 15:07:48 +0530 | [diff] [blame] | 375 | "target_ref_field": target_ref_field, |
Nabin Hait | bdab0ee | 2015-12-30 19:08:11 +0530 | [diff] [blame] | 376 | "target_field": "billed_amt", |
| 377 | "name": self.name, |
Anand Doshi | 6b71ef5 | 2016-01-06 16:32:06 +0530 | [diff] [blame] | 378 | }, update_modified) |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 379 | |
Nabin Hait | 8af429d | 2016-11-16 17:21:59 +0530 | [diff] [blame] | 380 | def validate_inspection(self): |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 381 | """Checks if quality inspection is set/ is valid for Items that require inspection.""" |
| 382 | inspection_fieldname_map = { |
| 383 | "Purchase Receipt": "inspection_required_before_purchase", |
| 384 | "Purchase Invoice": "inspection_required_before_purchase", |
| 385 | "Sales Invoice": "inspection_required_before_delivery", |
| 386 | "Delivery Note": "inspection_required_before_delivery" |
| 387 | } |
| 388 | inspection_required_fieldname = inspection_fieldname_map.get(self.doctype) |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 389 | |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 390 | # return if inspection is not required on document level |
rohitwaghchaure | 4e8fdf7 | 2018-02-22 11:03:48 +0530 | [diff] [blame] | 391 | if ((not inspection_required_fieldname and self.doctype != "Stock Entry") or |
| 392 | (self.doctype == "Stock Entry" and not self.inspection_required) or |
| 393 | (self.doctype in ["Sales Invoice", "Purchase Invoice"] and not self.update_stock)): |
Nabin Hait | 8af429d | 2016-11-16 17:21:59 +0530 | [diff] [blame] | 394 | return |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 395 | |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 396 | for row in self.get('items'): |
| 397 | qi_required = False |
| 398 | if (inspection_required_fieldname and frappe.db.get_value("Item", row.item_code, inspection_required_fieldname)): |
| 399 | qi_required = True |
| 400 | elif self.doctype == "Stock Entry" and row.t_warehouse: |
| 401 | qi_required = True # inward stock needs inspection |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 402 | |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 403 | if qi_required: # validate row only if inspection is required on item level |
| 404 | self.validate_qi_presence(row) |
| 405 | if self.docstatus == 1: |
| 406 | self.validate_qi_submission(row) |
| 407 | self.validate_qi_rejection(row) |
| 408 | |
| 409 | def validate_qi_presence(self, row): |
| 410 | """Check if QI is present on row level. Warn on save and stop on submit if missing.""" |
| 411 | if not row.quality_inspection: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 412 | msg = f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}" |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 413 | if self.docstatus == 1: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 414 | frappe.throw(_(msg), title=_("Inspection Required"), exc=QualityInspectionRequiredError) |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 415 | else: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 416 | frappe.msgprint(_(msg), title=_("Inspection Required"), indicator="blue") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 417 | |
| 418 | def validate_qi_submission(self, row): |
| 419 | """Check if QI is submitted on row level, during submission""" |
marination | f67f13c | 2021-07-10 18:24:24 +0530 | [diff] [blame] | 420 | action = frappe.db.get_single_value("Stock Settings", "action_if_quality_inspection_is_not_submitted") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 421 | qa_docstatus = frappe.db.get_value("Quality Inspection", row.quality_inspection, "docstatus") |
| 422 | |
| 423 | if not qa_docstatus == 1: |
| 424 | link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection) |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 425 | msg = f"Row #{row.idx}: Quality Inspection {link} is not submitted for the item: {row.item_code}" |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 426 | if action == "Stop": |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 427 | frappe.throw(_(msg), title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError) |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 428 | else: |
Marica | 9ba3fce | 2021-06-22 11:20:17 +0530 | [diff] [blame] | 429 | frappe.msgprint(_(msg), alert=True, indicator="orange") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 430 | |
| 431 | def validate_qi_rejection(self, row): |
| 432 | """Check if QI is rejected on row level, during submission""" |
marination | f67f13c | 2021-07-10 18:24:24 +0530 | [diff] [blame] | 433 | action = frappe.db.get_single_value("Stock Settings", "action_if_quality_inspection_is_rejected") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 434 | qa_status = frappe.db.get_value("Quality Inspection", row.quality_inspection, "status") |
| 435 | |
| 436 | if qa_status == "Rejected": |
| 437 | link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection) |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 438 | msg = f"Row #{row.idx}: Quality Inspection {link} was rejected for item {row.item_code}" |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 439 | if action == "Stop": |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 440 | frappe.throw(_(msg), title=_("Inspection Rejected"), exc=QualityInspectionRejectedError) |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 441 | else: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 442 | frappe.msgprint(_(msg), alert=True, indicator="orange") |
Manas Solanki | cc90241 | 2016-11-10 19:15:11 +0530 | [diff] [blame] | 443 | |
Nabin Hait | b2d3c0f | 2018-06-14 15:54:34 +0530 | [diff] [blame] | 444 | def update_blanket_order(self): |
Nabin Hait | d1f40ad | 2018-06-14 17:09:55 +0530 | [diff] [blame] | 445 | blanket_orders = list(set([d.blanket_order for d in self.items if d.blanket_order])) |
Nabin Hait | b2d3c0f | 2018-06-14 15:54:34 +0530 | [diff] [blame] | 446 | for blanket_order in blanket_orders: |
| 447 | frappe.get_doc("Blanket Order", blanket_order).update_ordered_qty() |
Manas Solanki | e5e87f7 | 2018-05-28 20:07:08 +0530 | [diff] [blame] | 448 | |
marination | fd04e96 | 2020-04-03 15:46:48 +0530 | [diff] [blame] | 449 | def validate_customer_provided_item(self): |
| 450 | for d in self.get('items'): |
| 451 | # Customer Provided parts will have zero valuation rate |
| 452 | if frappe.db.get_value('Item', d.item_code, 'is_customer_provided_item'): |
| 453 | d.allow_zero_valuation_rate = 1 |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 454 | |
Anupam Kumar | 7e1dcf9 | 2021-02-11 20:19:30 +0530 | [diff] [blame] | 455 | def set_rate_of_stock_uom(self): |
| 456 | if self.doctype in ["Purchase Receipt", "Purchase Invoice", "Purchase Order", "Sales Invoice", "Sales Order", "Delivery Note", "Quotation"]: |
| 457 | for d in self.get("items"): |
Rohit Waghchaure | 1358443 | 2021-03-26 14:11:50 +0530 | [diff] [blame] | 458 | d.stock_uom_rate = d.rate / (d.conversion_factor or 1) |
Anupam Kumar | 7e1dcf9 | 2021-02-11 20:19:30 +0530 | [diff] [blame] | 459 | |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 460 | def validate_internal_transfer(self): |
| 461 | if self.doctype in ('Sales Invoice', 'Delivery Note', 'Purchase Invoice', 'Purchase Receipt') \ |
| 462 | and self.is_internal_transfer(): |
| 463 | self.validate_in_transit_warehouses() |
| 464 | self.validate_multi_currency() |
| 465 | self.validate_packed_items() |
| 466 | |
| 467 | def validate_in_transit_warehouses(self): |
| 468 | if (self.doctype == 'Sales Invoice' and self.get('update_stock')) or self.doctype == 'Delivery Note': |
| 469 | for item in self.get('items'): |
| 470 | if not item.target_warehouse: |
| 471 | frappe.throw(_("Row {0}: Target Warehouse is mandatory for internal transfers").format(item.idx)) |
| 472 | |
| 473 | if (self.doctype == 'Purchase Invoice' and self.get('update_stock')) or self.doctype == 'Purchase Receipt': |
| 474 | for item in self.get('items'): |
| 475 | if not item.from_warehouse: |
| 476 | frappe.throw(_("Row {0}: From Warehouse is mandatory for internal transfers").format(item.idx)) |
| 477 | |
| 478 | def validate_multi_currency(self): |
| 479 | if self.currency != self.company_currency: |
| 480 | frappe.throw(_("Internal transfers can only be done in company's default currency")) |
| 481 | |
| 482 | def validate_packed_items(self): |
| 483 | if self.doctype in ('Sales Invoice', 'Delivery Note Item') and self.get('packed_items'): |
| 484 | frappe.throw(_("Packed Items cannot be transferred internally")) |
| 485 | |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 486 | def validate_putaway_capacity(self): |
| 487 | # if over receipt is attempted while 'apply putaway rule' is disabled |
| 488 | # and if rule was applied on the transaction, validate it. |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 489 | from erpnext.stock.doctype.putaway_rule.putaway_rule import get_available_putaway_capacity |
| 490 | valid_doctype = self.doctype in ("Purchase Receipt", "Stock Entry", "Purchase Invoice", |
| 491 | "Stock Reconciliation") |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 492 | |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 493 | if self.doctype == "Purchase Invoice" and self.get("update_stock") == 0: |
| 494 | valid_doctype = False |
| 495 | |
| 496 | if valid_doctype: |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 497 | rule_map = defaultdict(dict) |
| 498 | for item in self.get("items"): |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 499 | warehouse_field = "t_warehouse" if self.doctype == "Stock Entry" else "warehouse" |
| 500 | rule = frappe.db.get_value("Putaway Rule", |
| 501 | { |
| 502 | "item_code": item.get("item_code"), |
| 503 | "warehouse": item.get(warehouse_field) |
| 504 | }, |
| 505 | ["name", "disable"], as_dict=True) |
| 506 | if rule: |
| 507 | if rule.get("disabled"): continue # dont validate for disabled rule |
| 508 | |
| 509 | if self.doctype == "Stock Reconciliation": |
| 510 | stock_qty = flt(item.qty) |
| 511 | else: |
| 512 | stock_qty = flt(item.transfer_qty) if self.doctype == "Stock Entry" else flt(item.stock_qty) |
| 513 | |
| 514 | rule_name = rule.get("name") |
| 515 | if not rule_map[rule_name]: |
| 516 | rule_map[rule_name]["warehouse"] = item.get(warehouse_field) |
| 517 | rule_map[rule_name]["item"] = item.get("item_code") |
| 518 | rule_map[rule_name]["qty_put"] = 0 |
| 519 | rule_map[rule_name]["capacity"] = get_available_putaway_capacity(rule_name) |
| 520 | rule_map[rule_name]["qty_put"] += flt(stock_qty) |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 521 | |
| 522 | for rule, values in rule_map.items(): |
| 523 | if flt(values["qty_put"]) > flt(values["capacity"]): |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 524 | message = self.prepare_over_receipt_message(rule, values) |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 525 | frappe.throw(msg=message, title=_("Over Receipt")) |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 526 | |
| 527 | def prepare_over_receipt_message(self, rule, values): |
| 528 | message = _("{0} qty of Item {1} is being received into Warehouse {2} with capacity {3}.") \ |
| 529 | .format( |
| 530 | frappe.bold(values["qty_put"]), frappe.bold(values["item"]), |
| 531 | frappe.bold(values["warehouse"]), frappe.bold(values["capacity"]) |
| 532 | ) |
| 533 | message += "<br><br>" |
| 534 | rule_link = frappe.utils.get_link_to_form("Putaway Rule", rule) |
Ankush Menat | ad6a265 | 2021-04-17 16:50:02 +0530 | [diff] [blame] | 535 | message += _("Please adjust the qty or edit {0} to proceed.").format(rule_link) |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 536 | return message |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 537 | |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 538 | def repost_future_sle_and_gle(self): |
| 539 | args = frappe._dict({ |
| 540 | "posting_date": self.posting_date, |
| 541 | "posting_time": self.posting_time, |
| 542 | "voucher_type": self.doctype, |
| 543 | "voucher_no": self.name, |
| 544 | "company": self.company |
| 545 | }) |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 546 | if future_sle_exists(args): |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 547 | create_repost_item_valuation_entry(args) |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 548 | |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 549 | @frappe.whitelist() |
| 550 | def make_quality_inspections(doctype, docname, items): |
Rohan Bansal | a06ec03 | 2021-06-02 14:55:31 +0530 | [diff] [blame] | 551 | if isinstance(items, str): |
| 552 | items = json.loads(items) |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 553 | |
Rohan Bansal | a06ec03 | 2021-06-02 14:55:31 +0530 | [diff] [blame] | 554 | inspections = [] |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 555 | for item in items: |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 556 | if flt(item.get("sample_size")) > flt(item.get("qty")): |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 557 | frappe.throw(_("{item_name}'s Sample Size ({sample_size}) cannot be greater than the Accepted Quantity ({accepted_quantity})").format( |
| 558 | item_name=item.get("item_name"), |
| 559 | sample_size=item.get("sample_size"), |
| 560 | accepted_quantity=item.get("qty") |
| 561 | )) |
| 562 | |
| 563 | quality_inspection = frappe.get_doc({ |
| 564 | "doctype": "Quality Inspection", |
| 565 | "inspection_type": "Incoming", |
| 566 | "inspected_by": frappe.session.user, |
| 567 | "reference_type": doctype, |
| 568 | "reference_name": docname, |
| 569 | "item_code": item.get("item_code"), |
| 570 | "description": item.get("description"), |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 571 | "sample_size": flt(item.get("sample_size")), |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 572 | "item_serial_no": item.get("serial_no").split("\n")[0] if item.get("serial_no") else None, |
| 573 | "batch_no": item.get("batch_no") |
| 574 | }).insert() |
| 575 | quality_inspection.save() |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 576 | inspections.append(quality_inspection.name) |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 577 | |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 578 | return inspections |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 579 | |
Nabin Hait | b99c77b | 2020-12-25 18:12:35 +0530 | [diff] [blame] | 580 | def is_reposting_pending(): |
| 581 | return frappe.db.exists("Repost Item Valuation", |
| 582 | {'docstatus': 1, 'status': ['in', ['Queued','In Progress']]}) |
| 583 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 584 | def future_sle_exists(args, sl_entries=None): |
| 585 | key = (args.voucher_type, args.voucher_no) |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 586 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 587 | if validate_future_sle_not_exists(args, key, sl_entries): |
| 588 | return False |
| 589 | elif get_cached_data(args, key): |
| 590 | return True |
| 591 | |
| 592 | if not sl_entries: |
| 593 | sl_entries = get_sle_entries_against_voucher(args) |
| 594 | if not sl_entries: |
| 595 | return |
| 596 | |
| 597 | or_conditions = get_conditions_to_validate_future_sle(sl_entries) |
| 598 | |
| 599 | data = frappe.db.sql(""" |
| 600 | select item_code, warehouse, count(name) as total_row |
Deepesh Garg | 6f107da | 2021-10-12 20:15:55 +0530 | [diff] [blame] | 601 | from `tabStock Ledger Entry` force index (item_warehouse) |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 602 | where |
| 603 | ({}) |
| 604 | and timestamp(posting_date, posting_time) |
| 605 | >= timestamp(%(posting_date)s, %(posting_time)s) |
| 606 | and voucher_no != %(voucher_no)s |
| 607 | and is_cancelled = 0 |
| 608 | GROUP BY |
| 609 | item_code, warehouse |
| 610 | """.format(" or ".join(or_conditions)), args, as_dict=1) |
| 611 | |
| 612 | for d in data: |
| 613 | frappe.local.future_sle[key][(d.item_code, d.warehouse)] = d.total_row |
| 614 | |
| 615 | return len(data) |
| 616 | |
| 617 | def validate_future_sle_not_exists(args, key, sl_entries=None): |
| 618 | item_key = '' |
| 619 | if args.get('item_code'): |
| 620 | item_key = (args.get('item_code'), args.get('warehouse')) |
| 621 | |
| 622 | if not sl_entries and hasattr(frappe.local, 'future_sle'): |
| 623 | if (not frappe.local.future_sle.get(key) or |
| 624 | (item_key and item_key not in frappe.local.future_sle.get(key))): |
| 625 | return True |
| 626 | |
| 627 | def get_cached_data(args, key): |
| 628 | if not hasattr(frappe.local, 'future_sle'): |
| 629 | frappe.local.future_sle = {} |
| 630 | |
| 631 | if key not in frappe.local.future_sle: |
| 632 | frappe.local.future_sle[key] = frappe._dict({}) |
| 633 | |
| 634 | if args.get('item_code'): |
| 635 | item_key = (args.get('item_code'), args.get('warehouse')) |
| 636 | count = frappe.local.future_sle[key].get(item_key) |
| 637 | |
| 638 | return True if (count or count == 0) else False |
| 639 | else: |
| 640 | return frappe.local.future_sle[key] |
| 641 | |
| 642 | def get_sle_entries_against_voucher(args): |
| 643 | return frappe.get_all("Stock Ledger Entry", |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 644 | filters={"voucher_type": args.voucher_type, "voucher_no": args.voucher_no}, |
| 645 | fields=["item_code", "warehouse"], |
| 646 | order_by="creation asc") |
| 647 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 648 | def get_conditions_to_validate_future_sle(sl_entries): |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 649 | warehouse_items_map = {} |
| 650 | for entry in sl_entries: |
| 651 | if entry.warehouse not in warehouse_items_map: |
| 652 | warehouse_items_map[entry.warehouse] = set() |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 653 | |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 654 | warehouse_items_map[entry.warehouse].add(entry.item_code) |
| 655 | |
| 656 | or_conditions = [] |
| 657 | for warehouse, items in warehouse_items_map.items(): |
| 658 | or_conditions.append( |
Noah Jacob | b5a1491 | 2021-06-15 12:44:04 +0530 | [diff] [blame] | 659 | f"""warehouse = {frappe.db.escape(warehouse)} |
| 660 | and item_code in ({', '.join(frappe.db.escape(item) for item in items)})""") |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 661 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 662 | return or_conditions |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 663 | |
| 664 | def create_repost_item_valuation_entry(args): |
| 665 | args = frappe._dict(args) |
| 666 | repost_entry = frappe.new_doc("Repost Item Valuation") |
| 667 | repost_entry.based_on = args.based_on |
| 668 | if not args.based_on: |
| 669 | repost_entry.based_on = 'Transaction' if args.voucher_no else "Item and Warehouse" |
| 670 | repost_entry.voucher_type = args.voucher_type |
| 671 | repost_entry.voucher_no = args.voucher_no |
| 672 | repost_entry.item_code = args.item_code |
| 673 | repost_entry.warehouse = args.warehouse |
| 674 | repost_entry.posting_date = args.posting_date |
| 675 | repost_entry.posting_time = args.posting_time |
| 676 | repost_entry.company = args.company |
| 677 | repost_entry.allow_zero_rate = args.allow_zero_rate |
| 678 | repost_entry.flags.ignore_links = True |
| 679 | repost_entry.save() |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 680 | repost_entry.submit() |