blob: 5137e030582e5d5f91d73cef5035bccaa562476a [file] [log] [blame]
Anand Doshi885e0742015-03-03 14:55:30 +05301# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
Rushabh Mehtae67d1fb2013-08-05 14:59:54 +05302# License: GNU General Public License v3. See license.txt
Nabin Haitc3afb252013-03-19 12:01:24 +05303
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05304import json
marinationfac40352020-12-07 21:35:49 +05305from collections import defaultdict
Ankush Menate6ab8df2022-02-06 13:02:34 +05306from typing import List, Tuple
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05307
8import frappe
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05309from frappe import _
Rohit Waghchaurebc75a7e2022-10-10 13:28:19 +053010from frappe.utils import cint, flt, get_link_to_form, getdate
Rohan Bansal7f8b95e2021-04-14 14:12:03 +053011
12import erpnext
Chillar Anand915b3432021-09-02 16:44:59 +053013from erpnext.accounts.general_ledger import (
14 make_gl_entries,
15 make_reverse_gl_entries,
16 process_gl_map,
17)
Rohit Waghchaure5d5dc562021-06-22 15:23:04 +053018from erpnext.accounts.utils import get_fiscal_year
Rushabh Mehta1f847992013-12-12 19:12:19 +053019from erpnext.controllers.accounts_controller import AccountsController
Nabin Hait6d7b0ce2017-06-15 11:09:27 +053020from erpnext.stock import get_warehouse_account_map
Rohit Waghchauredbec5cf2022-06-22 12:24:08 +053021from erpnext.stock.doctype.inventory_dimension.inventory_dimension import (
22 get_evaluated_inventory_dimension,
23)
Ankush Menat8f577242022-01-07 11:10:23 +053024from erpnext.stock.stock_ledger import get_items_to_be_repost
Rohan Bansal7f8b95e2021-04-14 14:12:03 +053025
Nabin Haitc3afb252013-03-19 12:01:24 +053026
Ankush Menat494bd9e2022-03-28 18:52:46 +053027class QualityInspectionRequiredError(frappe.ValidationError):
28 pass
29
30
31class QualityInspectionRejectedError(frappe.ValidationError):
32 pass
33
34
35class QualityInspectionNotSubmittedError(frappe.ValidationError):
36 pass
37
Nabin Hait5a9579b2018-12-24 14:54:42 +053038
Rohit Waghchaure795c9432022-08-17 13:48:56 +053039class BatchExpiredError(frappe.ValidationError):
40 pass
41
42
Nabin Haitc3afb252013-03-19 12:01:24 +053043class StockController(AccountsController):
Nabin Hait8af429d2016-11-16 17:21:59 +053044 def validate(self):
45 super(StockController, self).validate()
Ankush Menat494bd9e2022-03-28 18:52:46 +053046 if not self.get("is_return"):
marination596560c2020-06-11 16:39:03 +053047 self.validate_inspection()
rohitwaghchaure9af557f2019-12-30 13:26:47 +053048 self.validate_serialized_batch()
marinationeecfc4c2021-07-22 13:23:54 +053049 self.clean_serial_nos()
marinationfd04e962020-04-03 15:46:48 +053050 self.validate_customer_provided_item()
Anupam Kumar7e1dcf92021-02-11 20:19:30 +053051 self.set_rate_of_stock_uom()
Deepesh Gargb4be2922021-01-28 13:09:56 +053052 self.validate_internal_transfer()
marinationfac40352020-12-07 21:35:49 +053053 self.validate_putaway_capacity()
Rushabh Mehtaffd80a62017-01-16 17:23:20 +053054
Nabin Haita77b8c92020-12-21 14:45:50 +053055 def make_gl_entries(self, gl_entries=None, from_repost=False):
Anand Doshif78d1ae2014-03-28 13:55:00 +053056 if self.docstatus == 2:
Deepesh Garg2a9c5ba2020-04-30 10:38:58 +053057 make_reverse_gl_entries(voucher_type=self.doctype, voucher_no=self.name)
Anand Doshi2ce39cf2014-04-07 18:51:58 +053058
Ankush Menat494bd9e2022-03-28 18:52:46 +053059 provisional_accounting_for_non_stock_items = cint(
Daizy Modi4efc9472022-11-07 09:21:03 +053060 frappe.get_cached_value(
Ankush Menat494bd9e2022-03-28 18:52:46 +053061 "Company", self.company, "enable_provisional_accounting_for_non_stock_items"
62 )
63 )
Deepesh Garg528c7132022-02-01 14:42:55 +053064
Ankush Menat494bd9e2022-03-28 18:52:46 +053065 if (
66 cint(erpnext.is_perpetual_inventory_enabled(self.company))
67 or provisional_accounting_for_non_stock_items
68 ):
Rohit Waghchaure6b33c9b2019-03-08 11:13:35 +053069 warehouse_account = get_warehouse_account_map(self.company)
Anand Doshi2ce39cf2014-04-07 18:51:58 +053070
Ankush Menat494bd9e2022-03-28 18:52:46 +053071 if self.docstatus == 1:
Nabin Hait9784d272016-12-30 16:21:35 +053072 if not gl_entries:
73 gl_entries = self.get_gl_entries(warehouse_account)
Nabin Haita77b8c92020-12-21 14:45:50 +053074 make_gl_entries(gl_entries, from_repost=from_repost)
Nabin Hait145e5e22013-10-22 23:51:41 +053075
Ankush Menat494bd9e2022-03-28 18:52:46 +053076 elif self.doctype in ["Purchase Receipt", "Purchase Invoice"] and self.docstatus == 1:
Rohit Waghchaure42169722018-05-16 18:16:08 +053077 gl_entries = []
78 gl_entries = self.get_asset_gl_entry(gl_entries)
Nabin Haita77b8c92020-12-21 14:45:50 +053079 make_gl_entries(gl_entries, from_repost=from_repost)
Anand Doshi2ce39cf2014-04-07 18:51:58 +053080
rohitwaghchaure9af557f2019-12-30 13:26:47 +053081 def validate_serialized_batch(self):
82 from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos
Ankush Menat494bd9e2022-03-28 18:52:46 +053083
Rohit Waghchaure795c9432022-08-17 13:48:56 +053084 is_material_issue = False
85 if self.doctype == "Stock Entry" and self.purpose == "Material Issue":
86 is_material_issue = True
87
rohitwaghchaure9af557f2019-12-30 13:26:47 +053088 for d in self.get("items"):
Ankush Menat494bd9e2022-03-28 18:52:46 +053089 if hasattr(d, "serial_no") and hasattr(d, "batch_no") and d.serial_no and d.batch_no:
90 serial_nos = frappe.get_all(
91 "Serial No",
Rohit Waghchaure6b482eb2021-07-23 16:40:45 +053092 fields=["batch_no", "name", "warehouse"],
Ankush Menat494bd9e2022-03-28 18:52:46 +053093 filters={"name": ("in", get_serial_nos(d.serial_no))},
Rohit Waghchaure6b482eb2021-07-23 16:40:45 +053094 )
95
96 for row in serial_nos:
97 if row.warehouse and row.batch_no != d.batch_no:
Ankush Menat494bd9e2022-03-28 18:52:46 +053098 frappe.throw(
99 _("Row #{0}: Serial No {1} does not belong to Batch {2}").format(
100 d.idx, row.name, d.batch_no
101 )
102 )
rohitwaghchaure9af557f2019-12-30 13:26:47 +0530103
Rohit Waghchaure795c9432022-08-17 13:48:56 +0530104 if is_material_issue:
105 continue
106
Saqib Ansari903055b2020-10-20 11:59:06 +0530107 if flt(d.qty) > 0.0 and d.get("batch_no") and self.get("posting_date") and self.docstatus < 2:
rohitwaghchaure28a48802020-04-28 13:01:43 +0530108 expiry_date = frappe.get_cached_value("Batch", d.get("batch_no"), "expiry_date")
109
110 if expiry_date and getdate(expiry_date) < getdate(self.posting_date):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530111 frappe.throw(
112 _("Row #{0}: The batch {1} has already expired.").format(
113 d.idx, get_link_to_form("Batch", d.get("batch_no"))
Rohit Waghchaure795c9432022-08-17 13:48:56 +0530114 ),
115 BatchExpiredError,
Ankush Menat494bd9e2022-03-28 18:52:46 +0530116 )
rohitwaghchaure28a48802020-04-28 13:01:43 +0530117
marinationeecfc4c2021-07-22 13:23:54 +0530118 def clean_serial_nos(self):
Ankush Menatb20df372022-01-24 19:19:58 +0530119 from erpnext.stock.doctype.serial_no.serial_no import clean_serial_no_string
120
marinationeecfc4c2021-07-22 13:23:54 +0530121 for row in self.get("items"):
122 if hasattr(row, "serial_no") and row.serial_no:
Ankush Menatb20df372022-01-24 19:19:58 +0530123 # remove extra whitespace and store one serial no on each line
124 row.serial_no = clean_serial_no_string(row.serial_no)
marinationeecfc4c2021-07-22 13:23:54 +0530125
Ankush Menat494bd9e2022-03-28 18:52:46 +0530126 for row in self.get("packed_items") or []:
Ankush Menate177c522022-01-24 19:28:26 +0530127 if hasattr(row, "serial_no") and row.serial_no:
128 # remove extra whitespace and store one serial no on each line
129 row.serial_no = clean_serial_no_string(row.serial_no)
130
Ankush Menat494bd9e2022-03-28 18:52:46 +0530131 def get_gl_entries(
132 self, warehouse_account=None, default_expense_account=None, default_cost_center=None
133 ):
Nabin Haitadeb9762014-10-06 11:53:52 +0530134
Nabin Hait142007a2013-09-17 15:15:16 +0530135 if not warehouse_account:
Rohit Waghchaure6b33c9b2019-03-08 11:13:35 +0530136 warehouse_account = get_warehouse_account_map(self.company)
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530137
Anand Doshide1a97d2014-04-17 11:37:46 +0530138 sle_map = self.get_stock_ledger_details()
139 voucher_details = self.get_voucher_details(default_expense_account, default_cost_center, sle_map)
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530140
Nabin Hait2e296fa2013-08-28 18:53:11 +0530141 gl_list = []
Nabin Hait7a75e102013-09-17 10:21:20 +0530142 warehouse_with_no_account = []
Nabin Hait19f8fa52021-02-22 22:27:22 +0530143 precision = self.get_debit_field_precision()
Nabin Hait8c61f342016-12-15 13:46:03 +0530144 for item_row in voucher_details:
145 sle_list = sle_map.get(item_row.name)
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530146 sle_rounding_diff = 0.0
Nabin Hait2e296fa2013-08-28 18:53:11 +0530147 if sle_list:
148 for sle in sle_list:
149 if warehouse_account.get(sle.warehouse):
Deepesh Gargf17ea2c2020-12-11 21:30:39 +0530150 # from warehouse account
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530151
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530152 sle_rounding_diff += flt(sle.stock_value_difference)
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530153
Nabin Hait8c61f342016-12-15 13:46:03 +0530154 self.check_expense_account(item_row)
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530155
Deepesh Gargf17ea2c2020-12-11 21:30:39 +0530156 # expense account/ target_warehouse / source_warehouse
Ankush Menat494bd9e2022-03-28 18:52:46 +0530157 if item_row.get("target_warehouse"):
158 warehouse = item_row.get("target_warehouse")
Deepesh Gargf17ea2c2020-12-11 21:30:39 +0530159 expense_account = warehouse_account[warehouse]["account"]
160 else:
161 expense_account = item_row.expense_account
162
Ankush Menat494bd9e2022-03-28 18:52:46 +0530163 gl_list.append(
164 self.get_gl_dict(
165 {
166 "account": warehouse_account[sle.warehouse]["account"],
167 "against": expense_account,
168 "cost_center": item_row.cost_center,
169 "project": item_row.project or self.get("project"),
170 "remarks": self.get("remarks") or _("Accounting Entry for Stock"),
171 "debit": flt(sle.stock_value_difference, precision),
172 "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No",
173 },
174 warehouse_account[sle.warehouse]["account_currency"],
175 item=item_row,
176 )
177 )
Nabin Hait27994c22013-08-26 16:53:30 +0530178
Ankush Menat494bd9e2022-03-28 18:52:46 +0530179 gl_list.append(
180 self.get_gl_dict(
181 {
182 "account": expense_account,
183 "against": warehouse_account[sle.warehouse]["account"],
184 "cost_center": item_row.cost_center,
185 "remarks": self.get("remarks") or _("Accounting Entry for Stock"),
Ankush Menat65b21ee2022-06-07 14:49:24 +0530186 "debit": -1 * flt(sle.stock_value_difference, precision),
Ankush Menat494bd9e2022-03-28 18:52:46 +0530187 "project": item_row.get("project") or self.get("project"),
188 "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No",
189 },
190 item=item_row,
191 )
192 )
Nabin Hait7a75e102013-09-17 10:21:20 +0530193 elif sle.warehouse not in warehouse_with_no_account:
194 warehouse_with_no_account.append(sle.warehouse)
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530195
Deepesh Garg9aa5e202022-10-12 15:53:28 +0530196 if abs(sle_rounding_diff) > (1.0 / (10**precision)) and self.is_internal_transfer():
Deepesh Garg1c05c002022-10-12 14:19:09 +0530197 warehouse_asset_account = ""
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530198 if self.get("is_internal_customer"):
Deepesh Garg1c05c002022-10-12 14:19:09 +0530199 warehouse_asset_account = warehouse_account[item_row.get("target_warehouse")]["account"]
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530200 elif self.get("is_internal_supplier"):
Deepesh Garg1c05c002022-10-12 14:19:09 +0530201 warehouse_asset_account = warehouse_account[item_row.get("warehouse")]["account"]
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530202
Daizy Modi4efc9472022-11-07 09:21:03 +0530203 expense_account = frappe.get_cached_value("Company", self.company, "default_expense_account")
Deepesh Garg1c05c002022-10-12 14:19:09 +0530204
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530205 gl_list.append(
206 self.get_gl_dict(
207 {
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530208 "account": expense_account,
Deepesh Garg1c05c002022-10-12 14:19:09 +0530209 "against": warehouse_asset_account,
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530210 "cost_center": item_row.cost_center,
211 "project": item_row.project or self.get("project"),
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530212 "remarks": _("Rounding gain/loss Entry for Stock Transfer"),
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530213 "debit": sle_rounding_diff,
214 "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No",
215 },
216 warehouse_account[sle.warehouse]["account_currency"],
217 item=item_row,
218 )
219 )
220
221 gl_list.append(
222 self.get_gl_dict(
223 {
Deepesh Garg1c05c002022-10-12 14:19:09 +0530224 "account": warehouse_asset_account,
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530225 "against": expense_account,
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530226 "cost_center": item_row.cost_center,
Deepesh Gargdf2a0e22022-10-11 14:55:09 +0530227 "remarks": _("Rounding gain/loss Entry for Stock Transfer"),
228 "credit": sle_rounding_diff,
Deepesh Garg6e47fd52022-09-26 21:15:57 +0530229 "project": item_row.get("project") or self.get("project"),
230 "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No",
231 },
232 item=item_row,
233 )
234 )
235
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530236 if warehouse_with_no_account:
Nabin Haitd6625022016-10-24 18:17:57 +0530237 for wh in warehouse_with_no_account:
Daizy Modi4efc9472022-11-07 09:21:03 +0530238 if frappe.get_cached_value("Warehouse", wh, "company"):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530239 frappe.throw(
240 _(
241 "Warehouse {0} is not linked to any account, please mention the account in the warehouse record or set default inventory account in company {1}."
242 ).format(wh, self.company)
243 )
Rushabh Mehta14a908b2015-10-15 12:28:20 +0530244
Nabin Hait19f8fa52021-02-22 22:27:22 +0530245 return process_gl_map(gl_list, precision=precision)
246
247 def get_debit_field_precision(self):
248 if not frappe.flags.debit_field_precision:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530249 frappe.flags.debit_field_precision = frappe.get_precision(
250 "GL Entry", "debit_in_account_currency"
251 )
Nabin Hait19f8fa52021-02-22 22:27:22 +0530252
253 return frappe.flags.debit_field_precision
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530254
Anand Doshide1a97d2014-04-17 11:37:46 +0530255 def get_voucher_details(self, default_expense_account, default_cost_center, sle_map):
256 if self.doctype == "Stock Reconciliation":
Nabin Hait3f119ec2019-05-16 17:28:39 +0530257 reconciliation_purpose = frappe.db.get_value(self.doctype, self.name, "purpose")
258 is_opening = "Yes" if reconciliation_purpose == "Opening Stock" else "No"
259 details = []
Nabin Hait34c551d2019-07-03 10:34:31 +0530260 for voucher_detail_no in sle_map:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530261 details.append(
262 frappe._dict(
263 {
264 "name": voucher_detail_no,
265 "expense_account": default_expense_account,
266 "cost_center": default_cost_center,
267 "is_opening": is_opening,
268 }
269 )
270 )
Nabin Hait3f119ec2019-05-16 17:28:39 +0530271 return details
Anand Doshide1a97d2014-04-17 11:37:46 +0530272 else:
Nabin Haitdd38a262014-12-26 13:15:21 +0530273 details = self.get("items")
Anand Doshi094610d2014-04-16 19:56:53 +0530274
Anand Doshide1a97d2014-04-17 11:37:46 +0530275 if default_expense_account or default_cost_center:
276 for d in details:
277 if default_expense_account and not d.get("expense_account"):
278 d.expense_account = default_expense_account
279 if default_cost_center and not d.get("cost_center"):
280 d.cost_center = default_cost_center
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530281
Anand Doshide1a97d2014-04-17 11:37:46 +0530282 return details
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530283
Ankush Menate6ab8df2022-02-06 13:02:34 +0530284 def get_items_and_warehouses(self) -> Tuple[List[str], List[str]]:
285 """Get list of items and warehouses affected by a transaction"""
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530286
Ankush Menate6ab8df2022-02-06 13:02:34 +0530287 if not (hasattr(self, "items") or hasattr(self, "packed_items")):
288 return [], []
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530289
Ankush Menate6ab8df2022-02-06 13:02:34 +0530290 item_rows = (self.get("items") or []) + (self.get("packed_items") or [])
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530291
Ankush Menate6ab8df2022-02-06 13:02:34 +0530292 items = {d.item_code for d in item_rows if d.item_code}
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530293
Ankush Menate6ab8df2022-02-06 13:02:34 +0530294 warehouses = set()
295 for d in item_rows:
296 if d.get("warehouse"):
297 warehouses.add(d.warehouse)
Nabin Haitbecf75d2014-03-27 17:18:29 +0530298
Ankush Menate6ab8df2022-02-06 13:02:34 +0530299 if self.doctype == "Stock Entry":
300 if d.get("s_warehouse"):
301 warehouses.add(d.s_warehouse)
302 if d.get("t_warehouse"):
303 warehouses.add(d.t_warehouse)
304
305 return list(items), list(warehouses)
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530306
Nabin Hait2e296fa2013-08-28 18:53:11 +0530307 def get_stock_ledger_details(self):
308 stock_ledger = {}
Ankush Menat494bd9e2022-03-28 18:52:46 +0530309 stock_ledger_entries = frappe.db.sql(
310 """
Rushabh Mehtacc8b2b22017-03-31 12:44:29 +0530311 select
Nabin Hait0a6aaf42017-02-07 01:23:26 +0530312 name, warehouse, stock_value_difference, valuation_rate,
Rushabh Mehtacc8b2b22017-03-31 12:44:29 +0530313 voucher_detail_no, item_code, posting_date, posting_time,
Nabin Hait0a6aaf42017-02-07 01:23:26 +0530314 actual_qty, qty_after_transaction
Nabin Haitea8fab52017-02-06 17:13:39 +0530315 from
316 `tabStock Ledger Entry`
317 where
Ankush Menat0ca60af2022-02-08 10:24:19 +0530318 voucher_type=%s and voucher_no=%s and is_cancelled = 0
Ankush Menat494bd9e2022-03-28 18:52:46 +0530319 """,
320 (self.doctype, self.name),
321 as_dict=True,
322 )
Nabin Hait0a6aaf42017-02-07 01:23:26 +0530323
Nabin Haitea8fab52017-02-06 17:13:39 +0530324 for sle in stock_ledger_entries:
Deepesh Gargb4be2922021-01-28 13:09:56 +0530325 stock_ledger.setdefault(sle.voucher_detail_no, []).append(sle)
Nabin Hait2e296fa2013-08-28 18:53:11 +0530326 return stock_ledger
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530327
Nabin Hait27994c22013-08-26 16:53:30 +0530328 def check_expense_account(self, item):
Rushabh Mehta052fe822014-04-16 19:20:11 +0530329 if not item.get("expense_account"):
Rohit Waghchaureceab6922020-11-18 17:57:35 +0530330 msg = _("Please set an Expense Account in the Items table")
Ankush Menat494bd9e2022-03-28 18:52:46 +0530331 frappe.throw(
332 _("Row #{0}: Expense Account not set for the Item {1}. {2}").format(
333 item.idx, frappe.bold(item.item_code), msg
334 ),
335 title=_("Expense Account Missing"),
336 )
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530337
Anand Doshi496123a2014-06-19 19:25:19 +0530338 else:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530339 is_expense_account = (
340 frappe.get_cached_value("Account", item.get("expense_account"), "report_type")
341 == "Profit and Loss"
342 )
343 if (
344 self.doctype
Sagar Sharma2d04e712022-08-17 15:57:41 +0530345 not in (
346 "Purchase Receipt",
347 "Purchase Invoice",
348 "Stock Reconciliation",
349 "Stock Entry",
350 "Subcontracting Receipt",
351 )
Ankush Menat494bd9e2022-03-28 18:52:46 +0530352 and not is_expense_account
353 ):
354 frappe.throw(
355 _("Expense / Difference account ({0}) must be a 'Profit or Loss' account").format(
356 item.get("expense_account")
357 )
358 )
Anand Doshi496123a2014-06-19 19:25:19 +0530359 if is_expense_account and not item.get("cost_center"):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530360 frappe.throw(
361 _("{0} {1}: Cost Center is mandatory for Item {2}").format(
362 _(self.doctype), self.name, item.get("item_code")
363 )
364 )
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530365
Rohit Waghchaure8996b7d2020-01-23 17:36:52 +0530366 def delete_auto_created_batches(self):
Rohit Waghchaurebc75a7e2022-10-10 13:28:19 +0530367 for row in self.items:
368 if row.serial_and_batch_bundle:
369 frappe.db.set_value(
370 "Serial and Batch Bundle", row.serial_and_batch_bundle, {"is_cancelled": 1}
371 )
Rohit Waghchaure8996b7d2020-01-23 17:36:52 +0530372
Rohit Waghchaurebc75a7e2022-10-10 13:28:19 +0530373 row.db_set("serial_and_batch_bundle", None)
Saqibe9ac3e02020-03-02 15:02:58 +0530374
Rohit Waghchaured3ceb072023-03-31 09:03:54 +0530375 def set_serial_and_batch_bundle(self, table_name=None, ignore_validate=False):
Rohit Waghchaure648efca2023-03-28 12:16:27 +0530376 if not table_name:
377 table_name = "items"
Rohit Waghchaure8996b7d2020-01-23 17:36:52 +0530378
Rohit Waghchaured3ceb072023-03-31 09:03:54 +0530379 QTY_FIELD = {
380 "serial_and_batch_bundle": "qty",
381 "current_serial_and_batch_bundle": "current_qty",
382 "rejected_serial_and_batch_bundle": "rejected_qty",
383 }
384
Rohit Waghchaure648efca2023-03-28 12:16:27 +0530385 for row in self.get(table_name):
Rohit Waghchaured3ceb072023-03-31 09:03:54 +0530386 for field in [
387 "serial_and_batch_bundle",
388 "current_serial_and_batch_bundle",
389 "rejected_serial_and_batch_bundle",
390 ]:
391 if row.get(field):
392 frappe.get_doc("Serial and Batch Bundle", row.get(field)).set_serial_and_batch_values(
393 self, row, qty_field=QTY_FIELD[field]
394 )
Rohit Waghchaure648efca2023-03-28 12:16:27 +0530395
Rohit Waghchaure86da3062023-03-20 14:15:34 +0530396 def make_package_for_transfer(
397 self, serial_and_batch_bundle, warehouse, type_of_transaction=None, do_not_submit=None
398 ):
399 bundle_doc = frappe.get_doc("Serial and Batch Bundle", serial_and_batch_bundle)
400
401 if not type_of_transaction:
402 type_of_transaction = "Inward"
403
404 bundle_doc = frappe.copy_doc(bundle_doc)
405 bundle_doc.warehouse = warehouse
406 bundle_doc.type_of_transaction = type_of_transaction
407 bundle_doc.voucher_type = self.doctype
408 bundle_doc.voucher_no = self.name
409 bundle_doc.is_cancelled = 0
410
Rohit Waghchaure5bb31732023-03-21 10:54:41 +0530411 for row in bundle_doc.entries:
Rohit Waghchaure86da3062023-03-20 14:15:34 +0530412 row.is_outward = 0
413 row.qty = abs(row.qty)
414 row.stock_value_difference = abs(row.stock_value_difference)
415 if type_of_transaction == "Outward":
416 row.qty *= -1
417 row.stock_value_difference *= row.stock_value_difference
418 row.is_outward = 1
419
420 row.warehouse = warehouse
421
Rohit Waghchaure5bb31732023-03-21 10:54:41 +0530422 bundle_doc.calculate_qty_and_amount()
Rohit Waghchaure86da3062023-03-20 14:15:34 +0530423 bundle_doc.flags.ignore_permissions = True
Rohit Waghchaured3ceb072023-03-31 09:03:54 +0530424 bundle_doc.save(ignore_permissions=True)
Rohit Waghchaure86da3062023-03-20 14:15:34 +0530425
Rohit Waghchaure86da3062023-03-20 14:15:34 +0530426 return bundle_doc.name
Rohit Waghchaure4f4dbf12020-01-23 12:42:42 +0530427
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530428 def get_sl_entries(self, d, args):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530429 sl_dict = frappe._dict(
430 {
431 "item_code": d.get("item_code", None),
432 "warehouse": d.get("warehouse", None),
Rohit Waghchaurebc75a7e2022-10-10 13:28:19 +0530433 "serial_and_batch_bundle": d.get("serial_and_batch_bundle"),
Ankush Menat494bd9e2022-03-28 18:52:46 +0530434 "posting_date": self.posting_date,
435 "posting_time": self.posting_time,
436 "fiscal_year": get_fiscal_year(self.posting_date, company=self.company)[0],
437 "voucher_type": self.doctype,
438 "voucher_no": self.name,
439 "voucher_detail_no": d.name,
440 "actual_qty": (self.docstatus == 1 and 1 or -1) * flt(d.get("stock_qty")),
Rohit Waghchaure2d5ccc02023-05-01 21:17:18 +0530441 "stock_uom": frappe.get_cached_value(
Ankush Menat494bd9e2022-03-28 18:52:46 +0530442 "Item", args.get("item_code") or d.get("item_code"), "stock_uom"
443 ),
444 "incoming_rate": 0,
445 "company": self.company,
Ankush Menat494bd9e2022-03-28 18:52:46 +0530446 "project": d.get("project") or self.get("project"),
447 "is_cancelled": 1 if self.docstatus == 2 else 0,
448 }
449 )
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530450
Nabin Hait1e2f20a2013-08-02 11:42:11 +0530451 sl_dict.update(args)
Rohit Waghchauree576f7f2022-06-30 19:12:06 +0530452 self.update_inventory_dimensions(d, sl_dict)
Rohit Waghchauredbec5cf2022-06-22 12:24:08 +0530453
Nabin Hait1e2f20a2013-08-02 11:42:11 +0530454 return sl_dict
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530455
Rohit Waghchauredbec5cf2022-06-22 12:24:08 +0530456 def update_inventory_dimensions(self, row, sl_dict) -> None:
Rohit Waghchaure23729992022-09-02 18:43:55 +0530457 # To handle delivery note and sales invoice
458 if row.get("item_row"):
459 row = row.get("item_row")
460
Rohit Waghchaure289e6cd2022-07-15 15:43:38 +0530461 dimensions = get_evaluated_inventory_dimension(row, sl_dict, parent_doc=self)
462 for dimension in dimensions:
Rohit Waghchaure0b39a012022-08-17 11:56:13 +0530463 if not dimension:
464 continue
465
Rohit Waghchaure6798b902023-05-09 16:07:14 +0530466 if self.doctype in [
467 "Purchase Invoice",
468 "Purchase Receipt",
469 "Sales Invoice",
470 "Delivery Note",
471 "Stock Entry",
472 ]:
Rohit Waghchaure38aaba52023-05-13 13:00:05 +0530473 if (
474 (
475 sl_dict.actual_qty > 0
476 and not self.get("is_return")
477 or sl_dict.actual_qty < 0
478 and self.get("is_return")
479 )
480 and self.doctype in ["Purchase Invoice", "Purchase Receipt"]
481 ) or (
482 (
483 sl_dict.actual_qty < 0
484 and not self.get("is_return")
485 or sl_dict.actual_qty > 0
486 and self.get("is_return")
487 )
488 and self.doctype in ["Sales Invoice", "Delivery Note", "Stock Entry"]
Rohit Waghchaure6798b902023-05-09 16:07:14 +0530489 ):
490 sl_dict[dimension.target_fieldname] = row.get(dimension.source_fieldname)
491 else:
492 fieldname_start_with = "to"
493 if self.doctype in ["Purchase Invoice", "Purchase Receipt"]:
494 fieldname_start_with = "from"
495
496 fieldname = f"{fieldname_start_with}_{dimension.source_fieldname}"
497 sl_dict[dimension.target_fieldname] = row.get(fieldname)
498
499 if not sl_dict.get(dimension.target_fieldname):
500 sl_dict[dimension.target_fieldname] = row.get(dimension.source_fieldname)
501
502 elif row.get(dimension.source_fieldname):
Rohit Waghchaure289e6cd2022-07-15 15:43:38 +0530503 sl_dict[dimension.target_fieldname] = row.get(dimension.source_fieldname)
Rohit Waghchauredbec5cf2022-06-22 12:24:08 +0530504
Rohit Waghchaure0b39a012022-08-17 11:56:13 +0530505 if not sl_dict.get(dimension.target_fieldname) and dimension.fetch_from_parent:
506 sl_dict[dimension.target_fieldname] = self.get(dimension.fetch_from_parent)
507
508 # Get value based on doctype name
509 if not sl_dict.get(dimension.target_fieldname):
Daizy Modi4efc9472022-11-07 09:21:03 +0530510 fieldname = next(
511 (
512 field.fieldname
513 for field in frappe.get_meta(self.doctype).fields
514 if field.options == dimension.fetch_from_parent
515 ),
516 None,
Rohit Waghchaure0b39a012022-08-17 11:56:13 +0530517 )
518
519 if fieldname and self.get(fieldname):
520 sl_dict[dimension.target_fieldname] = self.get(fieldname)
521
Rohit Waghchaure75fcab02022-09-03 17:09:24 +0530522 if sl_dict[dimension.target_fieldname] and self.docstatus == 1:
523 row.db_set(dimension.source_fieldname, sl_dict[dimension.target_fieldname])
Rohit Waghchaure23729992022-09-02 18:43:55 +0530524
Ankush Menat494bd9e2022-03-28 18:52:46 +0530525 def make_sl_entries(self, sl_entries, allow_negative_stock=False, via_landed_cost_voucher=False):
Rushabh Mehta1f847992013-12-12 19:12:19 +0530526 from erpnext.stock.stock_ledger import make_sl_entries
Ankush Menat494bd9e2022-03-28 18:52:46 +0530527
Deepesh Garg2a9c5ba2020-04-30 10:38:58 +0530528 make_sl_entries(sl_entries, allow_negative_stock, via_landed_cost_voucher)
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530529
Deepesh Garg2a9c5ba2020-04-30 10:38:58 +0530530 def make_gl_entries_on_cancel(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530531 if frappe.db.sql(
532 """select name from `tabGL Entry` where voucher_type=%s
533 and voucher_no=%s""",
534 (self.doctype, self.name),
535 ):
536 self.make_gl_entries()
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530537
Anand Doshia740f752014-06-25 13:31:02 +0530538 def get_serialized_items(self):
539 serialized_items = []
Ankush Menata9c84f72021-06-11 16:00:48 +0530540 item_codes = list(set(d.item_code for d in self.get("items")))
Anand Doshia740f752014-06-25 13:31:02 +0530541 if item_codes:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530542 serialized_items = frappe.db.sql_list(
543 """select name from `tabItem`
544 where has_serial_no=1 and name in ({})""".format(
545 ", ".join(["%s"] * len(item_codes))
546 ),
547 tuple(item_codes),
548 )
Anand Doshia740f752014-06-25 13:31:02 +0530549
550 return serialized_items
Rushabh Mehtab16b9cd2015-08-03 16:13:33 +0530551
Saurabh2e292062015-11-18 17:03:33 +0530552 def validate_warehouse(self):
Rohan Bansal7f8b95e2021-04-14 14:12:03 +0530553 from erpnext.stock.utils import validate_disabled_warehouse, validate_warehouse_company
Saurabh2e292062015-11-18 17:03:33 +0530554
Ankush Menat494bd9e2022-03-28 18:52:46 +0530555 warehouses = list(set(d.warehouse for d in self.get("items") if getattr(d, "warehouse", None)))
Saurabh2e292062015-11-18 17:03:33 +0530556
Ankush Menat494bd9e2022-03-28 18:52:46 +0530557 target_warehouses = list(
558 set([d.target_warehouse for d in self.get("items") if getattr(d, "target_warehouse", None)])
559 )
Deepesh Garg15ff6a52020-02-18 12:28:41 +0530560
561 warehouses.extend(target_warehouses)
562
Ankush Menat494bd9e2022-03-28 18:52:46 +0530563 from_warehouse = list(
564 set([d.from_warehouse for d in self.get("items") if getattr(d, "from_warehouse", None)])
565 )
Deepesh Garg15ff6a52020-02-18 12:28:41 +0530566
567 warehouses.extend(from_warehouse)
568
Saurabh2e292062015-11-18 17:03:33 +0530569 for w in warehouses:
Jannat Patel30c88732021-02-11 11:46:48 +0530570 validate_disabled_warehouse(w)
Saurabh2e292062015-11-18 17:03:33 +0530571 validate_warehouse_company(w, self.company)
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530572
Anand Doshi6b71ef52016-01-06 16:32:06 +0530573 def update_billing_percentage(self, update_modified=True):
marinationd6596a12020-11-02 15:07:48 +0530574 target_ref_field = "amount"
575 if self.doctype == "Delivery Note":
576 target_ref_field = "amount - (returned_qty * rate)"
577
Ankush Menat494bd9e2022-03-28 18:52:46 +0530578 self._update_percent_field(
579 {
580 "target_dt": self.doctype + " Item",
581 "target_parent_dt": self.doctype,
582 "target_parent_field": "per_billed",
583 "target_ref_field": target_ref_field,
584 "target_field": "billed_amt",
585 "name": self.name,
586 },
587 update_modified,
588 )
Anand Doshia740f752014-06-25 13:31:02 +0530589
Nabin Hait8af429d2016-11-16 17:21:59 +0530590 def validate_inspection(self):
marination9ac9a4e2021-06-21 16:18:35 +0530591 """Checks if quality inspection is set/ is valid for Items that require inspection."""
592 inspection_fieldname_map = {
593 "Purchase Receipt": "inspection_required_before_purchase",
594 "Purchase Invoice": "inspection_required_before_purchase",
595 "Sales Invoice": "inspection_required_before_delivery",
Ankush Menat494bd9e2022-03-28 18:52:46 +0530596 "Delivery Note": "inspection_required_before_delivery",
marination9ac9a4e2021-06-21 16:18:35 +0530597 }
598 inspection_required_fieldname = inspection_fieldname_map.get(self.doctype)
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530599
marination9ac9a4e2021-06-21 16:18:35 +0530600 # return if inspection is not required on document level
Ankush Menat494bd9e2022-03-28 18:52:46 +0530601 if (
602 (not inspection_required_fieldname and self.doctype != "Stock Entry")
603 or (self.doctype == "Stock Entry" and not self.inspection_required)
604 or (self.doctype in ["Sales Invoice", "Purchase Invoice"] and not self.update_stock)
605 ):
606 return
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530607
Ankush Menat494bd9e2022-03-28 18:52:46 +0530608 for row in self.get("items"):
marination9ac9a4e2021-06-21 16:18:35 +0530609 qi_required = False
Ankush Menat494bd9e2022-03-28 18:52:46 +0530610 if inspection_required_fieldname and frappe.db.get_value(
611 "Item", row.item_code, inspection_required_fieldname
612 ):
marination9ac9a4e2021-06-21 16:18:35 +0530613 qi_required = True
614 elif self.doctype == "Stock Entry" and row.t_warehouse:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530615 qi_required = True # inward stock needs inspection
Rushabh Mehtaffd80a62017-01-16 17:23:20 +0530616
Ankush Menat494bd9e2022-03-28 18:52:46 +0530617 if qi_required: # validate row only if inspection is required on item level
marination9ac9a4e2021-06-21 16:18:35 +0530618 self.validate_qi_presence(row)
619 if self.docstatus == 1:
620 self.validate_qi_submission(row)
621 self.validate_qi_rejection(row)
622
623 def validate_qi_presence(self, row):
624 """Check if QI is present on row level. Warn on save and stop on submit if missing."""
625 if not row.quality_inspection:
marination654e9d82021-06-21 16:51:12 +0530626 msg = f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}"
marination9ac9a4e2021-06-21 16:18:35 +0530627 if self.docstatus == 1:
marination654e9d82021-06-21 16:51:12 +0530628 frappe.throw(_(msg), title=_("Inspection Required"), exc=QualityInspectionRequiredError)
marination9ac9a4e2021-06-21 16:18:35 +0530629 else:
marination654e9d82021-06-21 16:51:12 +0530630 frappe.msgprint(_(msg), title=_("Inspection Required"), indicator="blue")
marination9ac9a4e2021-06-21 16:18:35 +0530631
632 def validate_qi_submission(self, row):
633 """Check if QI is submitted on row level, during submission"""
Ankush Menat494bd9e2022-03-28 18:52:46 +0530634 action = frappe.db.get_single_value(
635 "Stock Settings", "action_if_quality_inspection_is_not_submitted"
636 )
marination9ac9a4e2021-06-21 16:18:35 +0530637 qa_docstatus = frappe.db.get_value("Quality Inspection", row.quality_inspection, "docstatus")
638
639 if not qa_docstatus == 1:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530640 link = frappe.utils.get_link_to_form("Quality Inspection", row.quality_inspection)
641 msg = (
642 f"Row #{row.idx}: Quality Inspection {link} is not submitted for the item: {row.item_code}"
643 )
marination9ac9a4e2021-06-21 16:18:35 +0530644 if action == "Stop":
marination654e9d82021-06-21 16:51:12 +0530645 frappe.throw(_(msg), title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError)
marination9ac9a4e2021-06-21 16:18:35 +0530646 else:
Marica9ba3fce2021-06-22 11:20:17 +0530647 frappe.msgprint(_(msg), alert=True, indicator="orange")
marination9ac9a4e2021-06-21 16:18:35 +0530648
649 def validate_qi_rejection(self, row):
650 """Check if QI is rejected on row level, during submission"""
marinationf67f13c2021-07-10 18:24:24 +0530651 action = frappe.db.get_single_value("Stock Settings", "action_if_quality_inspection_is_rejected")
marination9ac9a4e2021-06-21 16:18:35 +0530652 qa_status = frappe.db.get_value("Quality Inspection", row.quality_inspection, "status")
653
654 if qa_status == "Rejected":
Ankush Menat494bd9e2022-03-28 18:52:46 +0530655 link = frappe.utils.get_link_to_form("Quality Inspection", row.quality_inspection)
marination654e9d82021-06-21 16:51:12 +0530656 msg = f"Row #{row.idx}: Quality Inspection {link} was rejected for item {row.item_code}"
marination9ac9a4e2021-06-21 16:18:35 +0530657 if action == "Stop":
marination654e9d82021-06-21 16:51:12 +0530658 frappe.throw(_(msg), title=_("Inspection Rejected"), exc=QualityInspectionRejectedError)
marination9ac9a4e2021-06-21 16:18:35 +0530659 else:
marination654e9d82021-06-21 16:51:12 +0530660 frappe.msgprint(_(msg), alert=True, indicator="orange")
Manas Solankicc902412016-11-10 19:15:11 +0530661
Nabin Haitb2d3c0f2018-06-14 15:54:34 +0530662 def update_blanket_order(self):
Nabin Haitd1f40ad2018-06-14 17:09:55 +0530663 blanket_orders = list(set([d.blanket_order for d in self.items if d.blanket_order]))
Nabin Haitb2d3c0f2018-06-14 15:54:34 +0530664 for blanket_order in blanket_orders:
665 frappe.get_doc("Blanket Order", blanket_order).update_ordered_qty()
Manas Solankie5e87f72018-05-28 20:07:08 +0530666
marinationfd04e962020-04-03 15:46:48 +0530667 def validate_customer_provided_item(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530668 for d in self.get("items"):
marinationfd04e962020-04-03 15:46:48 +0530669 # Customer Provided parts will have zero valuation rate
Rohit Waghchaure2d5ccc02023-05-01 21:17:18 +0530670 if frappe.get_cached_value("Item", d.item_code, "is_customer_provided_item"):
marinationfd04e962020-04-03 15:46:48 +0530671 d.allow_zero_valuation_rate = 1
Anand Doshi2ce39cf2014-04-07 18:51:58 +0530672
Anupam Kumar7e1dcf92021-02-11 20:19:30 +0530673 def set_rate_of_stock_uom(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530674 if self.doctype in [
675 "Purchase Receipt",
676 "Purchase Invoice",
677 "Purchase Order",
678 "Sales Invoice",
679 "Sales Order",
680 "Delivery Note",
681 "Quotation",
682 ]:
Anupam Kumar7e1dcf92021-02-11 20:19:30 +0530683 for d in self.get("items"):
Rohit Waghchaure13584432021-03-26 14:11:50 +0530684 d.stock_uom_rate = d.rate / (d.conversion_factor or 1)
Anupam Kumar7e1dcf92021-02-11 20:19:30 +0530685
Deepesh Gargb4be2922021-01-28 13:09:56 +0530686 def validate_internal_transfer(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530687 if (
688 self.doctype in ("Sales Invoice", "Delivery Note", "Purchase Invoice", "Purchase Receipt")
689 and self.is_internal_transfer()
690 ):
Deepesh Gargb4be2922021-01-28 13:09:56 +0530691 self.validate_in_transit_warehouses()
692 self.validate_multi_currency()
693 self.validate_packed_items()
694
695 def validate_in_transit_warehouses(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530696 if (
697 self.doctype == "Sales Invoice" and self.get("update_stock")
698 ) or self.doctype == "Delivery Note":
699 for item in self.get("items"):
Deepesh Gargb4be2922021-01-28 13:09:56 +0530700 if not item.target_warehouse:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530701 frappe.throw(
702 _("Row {0}: Target Warehouse is mandatory for internal transfers").format(item.idx)
703 )
Deepesh Gargb4be2922021-01-28 13:09:56 +0530704
Ankush Menat494bd9e2022-03-28 18:52:46 +0530705 if (
706 self.doctype == "Purchase Invoice" and self.get("update_stock")
707 ) or self.doctype == "Purchase Receipt":
708 for item in self.get("items"):
Deepesh Gargb4be2922021-01-28 13:09:56 +0530709 if not item.from_warehouse:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530710 frappe.throw(
711 _("Row {0}: From Warehouse is mandatory for internal transfers").format(item.idx)
712 )
Deepesh Gargb4be2922021-01-28 13:09:56 +0530713
714 def validate_multi_currency(self):
715 if self.currency != self.company_currency:
716 frappe.throw(_("Internal transfers can only be done in company's default currency"))
717
718 def validate_packed_items(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530719 if self.doctype in ("Sales Invoice", "Delivery Note Item") and self.get("packed_items"):
Deepesh Gargb4be2922021-01-28 13:09:56 +0530720 frappe.throw(_("Packed Items cannot be transferred internally"))
721
marinationfac40352020-12-07 21:35:49 +0530722 def validate_putaway_capacity(self):
723 # if over receipt is attempted while 'apply putaway rule' is disabled
724 # and if rule was applied on the transaction, validate it.
marination957615b2021-01-18 23:47:24 +0530725 from erpnext.stock.doctype.putaway_rule.putaway_rule import get_available_putaway_capacity
Ankush Menat494bd9e2022-03-28 18:52:46 +0530726
727 valid_doctype = self.doctype in (
728 "Purchase Receipt",
729 "Stock Entry",
730 "Purchase Invoice",
731 "Stock Reconciliation",
732 )
marinationfac40352020-12-07 21:35:49 +0530733
marination957615b2021-01-18 23:47:24 +0530734 if self.doctype == "Purchase Invoice" and self.get("update_stock") == 0:
735 valid_doctype = False
736
737 if valid_doctype:
marinationfac40352020-12-07 21:35:49 +0530738 rule_map = defaultdict(dict)
739 for item in self.get("items"):
marination957615b2021-01-18 23:47:24 +0530740 warehouse_field = "t_warehouse" if self.doctype == "Stock Entry" else "warehouse"
Ankush Menat494bd9e2022-03-28 18:52:46 +0530741 rule = frappe.db.get_value(
742 "Putaway Rule",
743 {"item_code": item.get("item_code"), "warehouse": item.get(warehouse_field)},
744 ["name", "disable"],
745 as_dict=True,
746 )
marination957615b2021-01-18 23:47:24 +0530747 if rule:
Ankush Menat494bd9e2022-03-28 18:52:46 +0530748 if rule.get("disabled"):
749 continue # dont validate for disabled rule
marination957615b2021-01-18 23:47:24 +0530750
751 if self.doctype == "Stock Reconciliation":
752 stock_qty = flt(item.qty)
753 else:
754 stock_qty = flt(item.transfer_qty) if self.doctype == "Stock Entry" else flt(item.stock_qty)
755
756 rule_name = rule.get("name")
757 if not rule_map[rule_name]:
758 rule_map[rule_name]["warehouse"] = item.get(warehouse_field)
759 rule_map[rule_name]["item"] = item.get("item_code")
760 rule_map[rule_name]["qty_put"] = 0
761 rule_map[rule_name]["capacity"] = get_available_putaway_capacity(rule_name)
762 rule_map[rule_name]["qty_put"] += flt(stock_qty)
marinationfac40352020-12-07 21:35:49 +0530763
764 for rule, values in rule_map.items():
765 if flt(values["qty_put"]) > flt(values["capacity"]):
marination957615b2021-01-18 23:47:24 +0530766 message = self.prepare_over_receipt_message(rule, values)
marinationfac40352020-12-07 21:35:49 +0530767 frappe.throw(msg=message, title=_("Over Receipt"))
marination957615b2021-01-18 23:47:24 +0530768
769 def prepare_over_receipt_message(self, rule, values):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530770 message = _(
771 "{0} qty of Item {1} is being received into Warehouse {2} with capacity {3}."
772 ).format(
773 frappe.bold(values["qty_put"]),
774 frappe.bold(values["item"]),
775 frappe.bold(values["warehouse"]),
776 frappe.bold(values["capacity"]),
777 )
marination957615b2021-01-18 23:47:24 +0530778 message += "<br><br>"
779 rule_link = frappe.utils.get_link_to_form("Putaway Rule", rule)
Ankush Menatad6a2652021-04-17 16:50:02 +0530780 message += _("Please adjust the qty or edit {0} to proceed.").format(rule_link)
marination957615b2021-01-18 23:47:24 +0530781 return message
marinationfac40352020-12-07 21:35:49 +0530782
Rohit Waghchaure2d5ccc02023-05-01 21:17:18 +0530783 def repost_future_sle_and_gle(self, force=False):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530784 args = frappe._dict(
785 {
786 "posting_date": self.posting_date,
787 "posting_time": self.posting_time,
788 "voucher_type": self.doctype,
789 "voucher_no": self.name,
790 "company": self.company,
791 }
792 )
Ankush Menat3638fbf2022-03-01 18:17:14 +0530793
Rohit Waghchaure6e661e72023-05-16 16:23:52 +0530794 if self.docstatus == 2:
795 force = True
796
Rohit Waghchaure2d5ccc02023-05-01 21:17:18 +0530797 if force or future_sle_exists(args) or repost_required_for_queue(self):
Ankush Menat494bd9e2022-03-28 18:52:46 +0530798 item_based_reposting = cint(
799 frappe.db.get_single_value("Stock Reposting Settings", "item_based_reposting")
800 )
Ankush Menat45dd46b2021-11-02 10:50:52 +0530801 if item_based_reposting:
802 create_item_wise_repost_entries(voucher_type=self.doctype, voucher_no=self.name)
803 else:
804 create_repost_item_valuation_entry(args)
805
Sagar Sharmaf4673942022-08-21 21:26:06 +0530806 def add_gl_entry(
807 self,
808 gl_entries,
809 account,
810 cost_center,
811 debit,
812 credit,
813 remarks,
814 against_account,
815 debit_in_account_currency=None,
816 credit_in_account_currency=None,
817 account_currency=None,
818 project=None,
819 voucher_detail_no=None,
820 item=None,
821 posting_date=None,
822 ):
823
824 gl_entry = {
825 "account": account,
826 "cost_center": cost_center,
827 "debit": debit,
828 "credit": credit,
829 "against": against_account,
830 "remarks": remarks,
831 }
832
833 if voucher_detail_no:
834 gl_entry.update({"voucher_detail_no": voucher_detail_no})
835
836 if debit_in_account_currency:
837 gl_entry.update({"debit_in_account_currency": debit_in_account_currency})
838
839 if credit_in_account_currency:
840 gl_entry.update({"credit_in_account_currency": credit_in_account_currency})
841
842 if posting_date:
843 gl_entry.update({"posting_date": posting_date})
844
845 gl_entries.append(self.get_gl_dict(gl_entry, item=item))
846
Ankush Menat494bd9e2022-03-28 18:52:46 +0530847
Deepesh Garg2e52a632023-06-04 19:20:28 +0530848@frappe.whitelist()
Deepesh Garg0e68da52023-06-22 15:43:32 +0530849def show_accounting_ledger_preview(company, doctype, docname):
Deepesh Garg0e68da52023-06-22 15:43:32 +0530850 filters = {"company": company, "include_dimensions": 1}
851 doc = frappe.get_doc(doctype, docname)
852
853 gl_columns, gl_data = get_accounting_ledger_preview(doc, filters)
854
Deepesh Gargd9e7bc52023-06-22 16:07:32 +0530855 frappe.db.rollback()
Deepesh Garg0e68da52023-06-22 15:43:32 +0530856
857 return {"gl_columns": gl_columns, "gl_data": gl_data}
858
859
860@frappe.whitelist()
861def show_stock_ledger_preview(company, doctype, docname):
Deepesh Garg2e52a632023-06-04 19:20:28 +0530862 filters = {"company": company}
863 doc = frappe.get_doc(doctype, docname)
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530864
Deepesh Garg011ac132023-06-12 18:42:49 +0530865 sl_columns, sl_data = get_stock_ledger_preview(doc, filters)
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530866
Deepesh Gargd9e7bc52023-06-22 16:07:32 +0530867 frappe.db.rollback()
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530868
Deepesh Garg2e52a632023-06-04 19:20:28 +0530869 return {
Deepesh Garg011ac132023-06-12 18:42:49 +0530870 "sl_columns": sl_columns,
871 "sl_data": sl_data,
Deepesh Garg2e52a632023-06-04 19:20:28 +0530872 }
873
874
Deepesh Garg011ac132023-06-12 18:42:49 +0530875def get_accounting_ledger_preview(doc, filters):
876 from erpnext.accounts.report.general_ledger.general_ledger import get_columns as get_gl_columns
877
878 gl_columns, gl_data = [], []
879 fields = [
880 "posting_date",
881 "account",
882 "debit",
883 "credit",
884 "against",
885 "party",
886 "party_type",
Deepesh Garg0e68da52023-06-22 15:43:32 +0530887 "cost_center",
Deepesh Garg011ac132023-06-12 18:42:49 +0530888 "against_voucher_type",
889 "against_voucher",
890 ]
891
892 doc.docstatus = 1
Deepesh Garg0e68da52023-06-22 15:43:32 +0530893
894 if doc.get("update_stock") or doc.doctype in ("Purchase Receipt", "Delivery Note"):
895 doc.update_stock_ledger()
896
Deepesh Garg011ac132023-06-12 18:42:49 +0530897 doc.make_gl_entries()
898 columns = get_gl_columns(filters)
899 gl_entries = get_gl_entries_for_preview(doc.doctype, doc.name, fields)
900
901 gl_columns = get_columns(columns, fields)
902 gl_data = get_data(fields, gl_entries)
903
904 return gl_columns, gl_data
905
906
907def get_stock_ledger_preview(doc, filters):
908 from erpnext.stock.report.stock_ledger.stock_ledger import get_columns as get_sl_columns
909
910 sl_columns, sl_data = [], []
911 fields = [
912 "item_code",
913 "stock_uom",
914 "actual_qty",
915 "qty_after_transaction",
916 "warehouse",
917 "incoming_rate",
918 "valuation_rate",
919 "stock_value",
920 "stock_value_difference",
921 ]
922 columns_fields = [
923 "item_code",
924 "stock_uom",
925 "in_qty",
926 "out_qty",
927 "qty_after_transaction",
928 "warehouse",
929 "incoming_rate",
Deepesh Garg0e68da52023-06-22 15:43:32 +0530930 "in_out_rate",
Deepesh Garg011ac132023-06-12 18:42:49 +0530931 "stock_value",
932 "stock_value_difference",
933 ]
934
Deepesh Garg0e68da52023-06-22 15:43:32 +0530935 if doc.get("update_stock") or doc.doctype in ("Purchase Receipt", "Delivery Note"):
Deepesh Garg011ac132023-06-12 18:42:49 +0530936 doc.docstatus = 1
937 doc.update_stock_ledger()
938 columns = get_sl_columns(filters)
939 sl_entries = get_sl_entries_for_preview(doc.doctype, doc.name, fields)
940
941 sl_columns = get_columns(columns, columns_fields)
942 sl_data = get_data(columns_fields, sl_entries)
943
944 return sl_columns, sl_data
945
946
947def get_sl_entries_for_preview(doctype, docname, fields):
948 sl_entries = frappe.get_all(
949 "Stock Ledger Entry", filters={"voucher_type": doctype, "voucher_no": docname}, fields=fields
950 )
951
952 for entry in sl_entries:
953 if entry.actual_qty > 0:
954 entry["in_qty"] = entry.actual_qty
955 entry["out_qty"] = 0
956 else:
957 entry["out_qty"] = abs(entry.actual_qty)
958 entry["in_qty"] = 0
959
Deepesh Garg0e68da52023-06-22 15:43:32 +0530960 entry["in_out_rate"] = entry["valuation_rate"]
961
Deepesh Garg011ac132023-06-12 18:42:49 +0530962 return sl_entries
963
964
965def get_gl_entries_for_preview(doctype, docname, fields):
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530966 return frappe.get_all(
Deepesh Garg011ac132023-06-12 18:42:49 +0530967 "GL Entry", filters={"voucher_type": doctype, "voucher_no": docname}, fields=fields
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530968 )
969
970
Deepesh Garg011ac132023-06-12 18:42:49 +0530971def get_columns(raw_columns, fields):
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530972 return [
Deepesh Garg011ac132023-06-12 18:42:49 +0530973 {"name": d.get("label"), "editable": False, "width": 110}
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530974 for d in raw_columns
Deepesh Garg011ac132023-06-12 18:42:49 +0530975 if not d.get("hidden") and d.get("fieldname") in fields
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530976 ]
977
978
979def get_data(raw_columns, raw_data):
980 datatable_data = []
981 for row in raw_data:
982 data_row = []
983 for column in raw_columns:
Deepesh Garg011ac132023-06-12 18:42:49 +0530984 data_row.append(row.get(column) or "")
Deepesh Garge30c3ea2023-06-12 11:46:51 +0530985
986 datatable_data.append(data_row)
987
988 return datatable_data
989
990
Ankush Menat3638fbf2022-03-01 18:17:14 +0530991def repost_required_for_queue(doc: StockController) -> bool:
992 """check if stock document contains repeated item-warehouse with queue based valuation.
993
994 if queue exists for repeated items then SLEs need to reprocessed in background again.
995 """
996
Ankush Menat494bd9e2022-03-28 18:52:46 +0530997 consuming_sles = frappe.db.get_all(
998 "Stock Ledger Entry",
Ankush Menat3638fbf2022-03-01 18:17:14 +0530999 filters={
1000 "voucher_type": doc.doctype,
1001 "voucher_no": doc.name,
1002 "actual_qty": ("<", 0),
Ankush Menat494bd9e2022-03-28 18:52:46 +05301003 "is_cancelled": 0,
Ankush Menat3638fbf2022-03-01 18:17:14 +05301004 },
Ankush Menat494bd9e2022-03-28 18:52:46 +05301005 fields=["item_code", "warehouse", "stock_queue"],
Ankush Menat3638fbf2022-03-01 18:17:14 +05301006 )
1007 item_warehouses = [(sle.item_code, sle.warehouse) for sle in consuming_sles]
1008
1009 unique_item_warehouses = set(item_warehouses)
1010
1011 if len(unique_item_warehouses) == len(item_warehouses):
1012 return False
1013
1014 for sle in consuming_sles:
1015 if sle.stock_queue != "[]": # using FIFO/LIFO valuation
1016 return True
1017 return False
1018
Nabin Hait19f8fa52021-02-22 22:27:22 +05301019
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301020@frappe.whitelist()
1021def make_quality_inspections(doctype, docname, items):
Rohan Bansala06ec032021-06-02 14:55:31 +05301022 if isinstance(items, str):
1023 items = json.loads(items)
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301024
Rohan Bansala06ec032021-06-02 14:55:31 +05301025 inspections = []
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301026 for item in items:
Rohan Bansal1cdf5a02021-05-26 14:42:15 +05301027 if flt(item.get("sample_size")) > flt(item.get("qty")):
Ankush Menat494bd9e2022-03-28 18:52:46 +05301028 frappe.throw(
1029 _(
1030 "{item_name}'s Sample Size ({sample_size}) cannot be greater than the Accepted Quantity ({accepted_quantity})"
1031 ).format(
1032 item_name=item.get("item_name"),
1033 sample_size=item.get("sample_size"),
1034 accepted_quantity=item.get("qty"),
1035 )
1036 )
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301037
Ankush Menat494bd9e2022-03-28 18:52:46 +05301038 quality_inspection = frappe.get_doc(
1039 {
1040 "doctype": "Quality Inspection",
1041 "inspection_type": "Incoming",
1042 "inspected_by": frappe.session.user,
1043 "reference_type": doctype,
1044 "reference_name": docname,
1045 "item_code": item.get("item_code"),
1046 "description": item.get("description"),
1047 "sample_size": flt(item.get("sample_size")),
1048 "item_serial_no": item.get("serial_no").split("\n")[0] if item.get("serial_no") else None,
1049 "batch_no": item.get("batch_no"),
1050 }
1051 ).insert()
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301052 quality_inspection.save()
Rohan Bansal1cdf5a02021-05-26 14:42:15 +05301053 inspections.append(quality_inspection.name)
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301054
Rohan Bansal1cdf5a02021-05-26 14:42:15 +05301055 return inspections
Rohan Bansal7f8b95e2021-04-14 14:12:03 +05301056
Ankush Menat494bd9e2022-03-28 18:52:46 +05301057
Nabin Haitb99c77b2020-12-25 18:12:35 +05301058def is_reposting_pending():
Ankush Menat494bd9e2022-03-28 18:52:46 +05301059 return frappe.db.exists(
1060 "Repost Item Valuation", {"docstatus": 1, "status": ["in", ["Queued", "In Progress"]]}
1061 )
1062
Nabin Haitb99c77b2020-12-25 18:12:35 +05301063
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301064def future_sle_exists(args, sl_entries=None):
1065 key = (args.voucher_type, args.voucher_no)
Rohit Waghchaured9dd64b2023-04-14 13:00:12 +05301066 if not hasattr(frappe.local, "future_sle"):
1067 frappe.local.future_sle = {}
Nabin Haita77b8c92020-12-21 14:45:50 +05301068
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301069 if validate_future_sle_not_exists(args, key, sl_entries):
1070 return False
1071 elif get_cached_data(args, key):
1072 return True
1073
1074 if not sl_entries:
1075 sl_entries = get_sle_entries_against_voucher(args)
1076 if not sl_entries:
1077 return
1078
1079 or_conditions = get_conditions_to_validate_future_sle(sl_entries)
1080
Ankush Menat494bd9e2022-03-28 18:52:46 +05301081 data = frappe.db.sql(
1082 """
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301083 select item_code, warehouse, count(name) as total_row
Deepesh Garg6f107da2021-10-12 20:15:55 +05301084 from `tabStock Ledger Entry` force index (item_warehouse)
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301085 where
1086 ({})
1087 and timestamp(posting_date, posting_time)
1088 >= timestamp(%(posting_date)s, %(posting_time)s)
1089 and voucher_no != %(voucher_no)s
1090 and is_cancelled = 0
1091 GROUP BY
1092 item_code, warehouse
Ankush Menat494bd9e2022-03-28 18:52:46 +05301093 """.format(
1094 " or ".join(or_conditions)
1095 ),
1096 args,
1097 as_dict=1,
1098 )
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301099
1100 for d in data:
1101 frappe.local.future_sle[key][(d.item_code, d.warehouse)] = d.total_row
1102
1103 return len(data)
1104
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301105
Ankush Menat494bd9e2022-03-28 18:52:46 +05301106def validate_future_sle_not_exists(args, key, sl_entries=None):
1107 item_key = ""
1108 if args.get("item_code"):
1109 item_key = (args.get("item_code"), args.get("warehouse"))
1110
1111 if not sl_entries and hasattr(frappe.local, "future_sle"):
Rohit Waghchaured9dd64b2023-04-14 13:00:12 +05301112 if key not in frappe.local.future_sle:
1113 return False
1114
Ankush Menat494bd9e2022-03-28 18:52:46 +05301115 if not frappe.local.future_sle.get(key) or (
1116 item_key and item_key not in frappe.local.future_sle.get(key)
1117 ):
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301118 return True
1119
Ankush Menat494bd9e2022-03-28 18:52:46 +05301120
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301121def get_cached_data(args, key):
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301122 if key not in frappe.local.future_sle:
Rohit Waghchaure2d5ccc02023-05-01 21:17:18 +05301123 frappe.local.future_sle[key] = frappe._dict({})
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301124
Ankush Menat494bd9e2022-03-28 18:52:46 +05301125 if args.get("item_code"):
1126 item_key = (args.get("item_code"), args.get("warehouse"))
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301127 count = frappe.local.future_sle[key].get(item_key)
1128
1129 return True if (count or count == 0) else False
1130 else:
1131 return frappe.local.future_sle[key]
1132
Ankush Menat494bd9e2022-03-28 18:52:46 +05301133
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301134def get_sle_entries_against_voucher(args):
Ankush Menat494bd9e2022-03-28 18:52:46 +05301135 return frappe.get_all(
1136 "Stock Ledger Entry",
Nabin Haita77b8c92020-12-21 14:45:50 +05301137 filters={"voucher_type": args.voucher_type, "voucher_no": args.voucher_no},
1138 fields=["item_code", "warehouse"],
Ankush Menat494bd9e2022-03-28 18:52:46 +05301139 order_by="creation asc",
1140 )
1141
Nabin Haita77b8c92020-12-21 14:45:50 +05301142
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301143def get_conditions_to_validate_future_sle(sl_entries):
Sagar Vora868c0bf2021-03-27 16:10:20 +05301144 warehouse_items_map = {}
1145 for entry in sl_entries:
1146 if entry.warehouse not in warehouse_items_map:
1147 warehouse_items_map[entry.warehouse] = set()
Nabin Haita77b8c92020-12-21 14:45:50 +05301148
Sagar Vora868c0bf2021-03-27 16:10:20 +05301149 warehouse_items_map[entry.warehouse].add(entry.item_code)
1150
1151 or_conditions = []
1152 for warehouse, items in warehouse_items_map.items():
1153 or_conditions.append(
Noah Jacobb5a14912021-06-15 12:44:04 +05301154 f"""warehouse = {frappe.db.escape(warehouse)}
Ankush Menat494bd9e2022-03-28 18:52:46 +05301155 and item_code in ({', '.join(frappe.db.escape(item) for item in items)})"""
1156 )
Sagar Vora868c0bf2021-03-27 16:10:20 +05301157
Rohit Waghchaure8520edc2021-06-15 10:21:44 +05301158 return or_conditions
Nabin Haita77b8c92020-12-21 14:45:50 +05301159
Ankush Menat494bd9e2022-03-28 18:52:46 +05301160
Nabin Haita77b8c92020-12-21 14:45:50 +05301161def create_repost_item_valuation_entry(args):
1162 args = frappe._dict(args)
1163 repost_entry = frappe.new_doc("Repost Item Valuation")
1164 repost_entry.based_on = args.based_on
1165 if not args.based_on:
Ankush Menat494bd9e2022-03-28 18:52:46 +05301166 repost_entry.based_on = "Transaction" if args.voucher_no else "Item and Warehouse"
Nabin Haita77b8c92020-12-21 14:45:50 +05301167 repost_entry.voucher_type = args.voucher_type
1168 repost_entry.voucher_no = args.voucher_no
1169 repost_entry.item_code = args.item_code
1170 repost_entry.warehouse = args.warehouse
1171 repost_entry.posting_date = args.posting_date
1172 repost_entry.posting_time = args.posting_time
1173 repost_entry.company = args.company
1174 repost_entry.allow_zero_rate = args.allow_zero_rate
1175 repost_entry.flags.ignore_links = True
Ankush Menataa024fc2021-11-18 12:51:26 +05301176 repost_entry.flags.ignore_permissions = True
Nabin Haita77b8c92020-12-21 14:45:50 +05301177 repost_entry.save()
Sagar Vora868c0bf2021-03-27 16:10:20 +05301178 repost_entry.submit()
Ankush Menat6dc9b822021-10-28 15:53:18 +05301179
1180
1181def create_item_wise_repost_entries(voucher_type, voucher_no, allow_zero_rate=False):
1182 """Using a voucher create repost item valuation records for all item-warehouse pairs."""
1183
Ankush Menatd220e082021-10-28 17:47:00 +05301184 stock_ledger_entries = get_items_to_be_repost(voucher_type, voucher_no)
1185
Ankush Menat6dc9b822021-10-28 15:53:18 +05301186 distinct_item_warehouses = set()
Ankush Menat6dc9b822021-10-28 15:53:18 +05301187 repost_entries = []
1188
1189 for sle in stock_ledger_entries:
1190 item_wh = (sle.item_code, sle.warehouse)
1191 if item_wh in distinct_item_warehouses:
1192 continue
1193 distinct_item_warehouses.add(item_wh)
1194
1195 repost_entry = frappe.new_doc("Repost Item Valuation")
1196 repost_entry.based_on = "Item and Warehouse"
1197 repost_entry.voucher_type = voucher_type
1198 repost_entry.voucher_no = voucher_no
1199
1200 repost_entry.item_code = sle.item_code
1201 repost_entry.warehouse = sle.warehouse
1202 repost_entry.posting_date = sle.posting_date
1203 repost_entry.posting_time = sle.posting_time
1204 repost_entry.allow_zero_rate = allow_zero_rate
1205 repost_entry.flags.ignore_links = True
Ankush Menat0a2964d2021-11-24 15:55:31 +05301206 repost_entry.flags.ignore_permissions = True
Ankush Menat6dc9b822021-10-28 15:53:18 +05301207 repost_entry.submit()
1208 repost_entries.append(repost_entry)
1209
1210 return repost_entries