Anand Doshi | 885e074 | 2015-03-03 14:55:30 +0530 | [diff] [blame] | 1 | # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors |
Rushabh Mehta | e67d1fb | 2013-08-05 14:59:54 +0530 | [diff] [blame] | 2 | # License: GNU General Public License v3. See license.txt |
Nabin Hait | c3afb25 | 2013-03-19 12:01:24 +0530 | [diff] [blame] | 3 | |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 4 | import json |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 5 | from collections import defaultdict |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 6 | from typing import List, Tuple |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 7 | |
| 8 | import frappe |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 9 | from frappe import _ |
| 10 | from frappe.utils import cint, cstr, flt, get_link_to_form, getdate |
| 11 | |
| 12 | import erpnext |
Chillar Anand | 915b343 | 2021-09-02 16:44:59 +0530 | [diff] [blame] | 13 | from erpnext.accounts.general_ledger import ( |
| 14 | make_gl_entries, |
| 15 | make_reverse_gl_entries, |
| 16 | process_gl_map, |
| 17 | ) |
Rohit Waghchaure | 5d5dc56 | 2021-06-22 15:23:04 +0530 | [diff] [blame] | 18 | from erpnext.accounts.utils import get_fiscal_year |
Rushabh Mehta | 1f84799 | 2013-12-12 19:12:19 +0530 | [diff] [blame] | 19 | from erpnext.controllers.accounts_controller import AccountsController |
Nabin Hait | 6d7b0ce | 2017-06-15 11:09:27 +0530 | [diff] [blame] | 20 | from erpnext.stock import get_warehouse_account_map |
Ankush Menat | 8f57724 | 2022-01-07 11:10:23 +0530 | [diff] [blame] | 21 | from erpnext.stock.stock_ledger import get_items_to_be_repost |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 22 | |
Nabin Hait | c3afb25 | 2013-03-19 12:01:24 +0530 | [diff] [blame] | 23 | |
Nabin Hait | 5a9579b | 2018-12-24 14:54:42 +0530 | [diff] [blame] | 24 | class QualityInspectionRequiredError(frappe.ValidationError): pass |
| 25 | class QualityInspectionRejectedError(frappe.ValidationError): pass |
Anurag Mishra | 0c8411d | 2018-12-28 16:53:00 +0530 | [diff] [blame] | 26 | class QualityInspectionNotSubmittedError(frappe.ValidationError): pass |
Nabin Hait | 5a9579b | 2018-12-24 14:54:42 +0530 | [diff] [blame] | 27 | |
Nabin Hait | c3afb25 | 2013-03-19 12:01:24 +0530 | [diff] [blame] | 28 | class StockController(AccountsController): |
Nabin Hait | 8af429d | 2016-11-16 17:21:59 +0530 | [diff] [blame] | 29 | def validate(self): |
| 30 | super(StockController, self).validate() |
Marica | fd3d976 | 2020-06-12 12:30:59 +0530 | [diff] [blame] | 31 | if not self.get('is_return'): |
marination | 596560c | 2020-06-11 16:39:03 +0530 | [diff] [blame] | 32 | self.validate_inspection() |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 33 | self.validate_serialized_batch() |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 34 | self.clean_serial_nos() |
marination | fd04e96 | 2020-04-03 15:46:48 +0530 | [diff] [blame] | 35 | self.validate_customer_provided_item() |
Anupam Kumar | 7e1dcf9 | 2021-02-11 20:19:30 +0530 | [diff] [blame] | 36 | self.set_rate_of_stock_uom() |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 37 | self.validate_internal_transfer() |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 38 | self.validate_putaway_capacity() |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 39 | |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 40 | def make_gl_entries(self, gl_entries=None, from_repost=False): |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 41 | if self.docstatus == 2: |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 42 | make_reverse_gl_entries(voucher_type=self.doctype, voucher_no=self.name) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 43 | |
Deepesh Garg | 528c713 | 2022-02-01 14:42:55 +0530 | [diff] [blame] | 44 | provisional_accounting_for_non_stock_items = \ |
| 45 | cint(frappe.db.get_value('Company', self.company, 'enable_provisional_accounting_for_non_stock_items')) |
| 46 | |
| 47 | if cint(erpnext.is_perpetual_inventory_enabled(self.company)) or provisional_accounting_for_non_stock_items: |
Rohit Waghchaure | 6b33c9b | 2019-03-08 11:13:35 +0530 | [diff] [blame] | 48 | warehouse_account = get_warehouse_account_map(self.company) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 49 | |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 50 | if self.docstatus==1: |
Nabin Hait | 9784d27 | 2016-12-30 16:21:35 +0530 | [diff] [blame] | 51 | if not gl_entries: |
| 52 | gl_entries = self.get_gl_entries(warehouse_account) |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 53 | make_gl_entries(gl_entries, from_repost=from_repost) |
Nabin Hait | 145e5e2 | 2013-10-22 23:51:41 +0530 | [diff] [blame] | 54 | |
Rohit Waghchaure | b6381c6 | 2018-06-12 13:54:40 +0530 | [diff] [blame] | 55 | elif self.doctype in ['Purchase Receipt', 'Purchase Invoice'] and self.docstatus == 1: |
Rohit Waghchaure | 4216972 | 2018-05-16 18:16:08 +0530 | [diff] [blame] | 56 | gl_entries = [] |
| 57 | gl_entries = self.get_asset_gl_entry(gl_entries) |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 58 | make_gl_entries(gl_entries, from_repost=from_repost) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 59 | |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 60 | def validate_serialized_batch(self): |
| 61 | from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos |
| 62 | for d in self.get("items"): |
| 63 | if hasattr(d, 'serial_no') and hasattr(d, 'batch_no') and d.serial_no and d.batch_no: |
Rohit Waghchaure | 6b482eb | 2021-07-23 16:40:45 +0530 | [diff] [blame] | 64 | serial_nos = frappe.get_all("Serial No", |
| 65 | fields=["batch_no", "name", "warehouse"], |
| 66 | filters={ |
| 67 | "name": ("in", get_serial_nos(d.serial_no)) |
| 68 | } |
| 69 | ) |
| 70 | |
| 71 | for row in serial_nos: |
| 72 | if row.warehouse and row.batch_no != d.batch_no: |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 73 | frappe.throw(_("Row #{0}: Serial No {1} does not belong to Batch {2}") |
Rohit Waghchaure | 6b482eb | 2021-07-23 16:40:45 +0530 | [diff] [blame] | 74 | .format(d.idx, row.name, d.batch_no)) |
rohitwaghchaure | 9af557f | 2019-12-30 13:26:47 +0530 | [diff] [blame] | 75 | |
Saqib Ansari | 903055b | 2020-10-20 11:59:06 +0530 | [diff] [blame] | 76 | if flt(d.qty) > 0.0 and d.get("batch_no") and self.get("posting_date") and self.docstatus < 2: |
rohitwaghchaure | 28a4880 | 2020-04-28 13:01:43 +0530 | [diff] [blame] | 77 | expiry_date = frappe.get_cached_value("Batch", d.get("batch_no"), "expiry_date") |
| 78 | |
| 79 | if expiry_date and getdate(expiry_date) < getdate(self.posting_date): |
| 80 | frappe.throw(_("Row #{0}: The batch {1} has already expired.") |
| 81 | .format(d.idx, get_link_to_form("Batch", d.get("batch_no")))) |
| 82 | |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 83 | def clean_serial_nos(self): |
Ankush Menat | b20df37 | 2022-01-24 19:19:58 +0530 | [diff] [blame] | 84 | from erpnext.stock.doctype.serial_no.serial_no import clean_serial_no_string |
| 85 | |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 86 | for row in self.get("items"): |
| 87 | if hasattr(row, "serial_no") and row.serial_no: |
Ankush Menat | b20df37 | 2022-01-24 19:19:58 +0530 | [diff] [blame] | 88 | # remove extra whitespace and store one serial no on each line |
| 89 | row.serial_no = clean_serial_no_string(row.serial_no) |
marination | eecfc4c | 2021-07-22 13:23:54 +0530 | [diff] [blame] | 90 | |
Ankush Menat | e177c52 | 2022-01-24 19:28:26 +0530 | [diff] [blame] | 91 | for row in self.get('packed_items') or []: |
| 92 | if hasattr(row, "serial_no") and row.serial_no: |
| 93 | # remove extra whitespace and store one serial no on each line |
| 94 | row.serial_no = clean_serial_no_string(row.serial_no) |
| 95 | |
Nabin Hait | e83069c | 2013-11-14 18:40:08 +0530 | [diff] [blame] | 96 | def get_gl_entries(self, warehouse_account=None, default_expense_account=None, |
Nabin Hait | 142007a | 2013-09-17 15:15:16 +0530 | [diff] [blame] | 97 | default_cost_center=None): |
Nabin Hait | adeb976 | 2014-10-06 11:53:52 +0530 | [diff] [blame] | 98 | |
Nabin Hait | 142007a | 2013-09-17 15:15:16 +0530 | [diff] [blame] | 99 | if not warehouse_account: |
Rohit Waghchaure | 6b33c9b | 2019-03-08 11:13:35 +0530 | [diff] [blame] | 100 | warehouse_account = get_warehouse_account_map(self.company) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 101 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 102 | sle_map = self.get_stock_ledger_details() |
| 103 | voucher_details = self.get_voucher_details(default_expense_account, default_cost_center, sle_map) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 104 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 105 | gl_list = [] |
Nabin Hait | 7a75e10 | 2013-09-17 10:21:20 +0530 | [diff] [blame] | 106 | warehouse_with_no_account = [] |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 107 | precision = self.get_debit_field_precision() |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 108 | for item_row in voucher_details: |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 109 | |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 110 | sle_list = sle_map.get(item_row.name) |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 111 | if sle_list: |
| 112 | for sle in sle_list: |
| 113 | if warehouse_account.get(sle.warehouse): |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 114 | # from warehouse account |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 115 | |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 116 | self.check_expense_account(item_row) |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 117 | |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 118 | # expense account/ target_warehouse / source_warehouse |
| 119 | if item_row.get('target_warehouse'): |
| 120 | warehouse = item_row.get('target_warehouse') |
| 121 | expense_account = warehouse_account[warehouse]["account"] |
| 122 | else: |
| 123 | expense_account = item_row.expense_account |
| 124 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 125 | gl_list.append(self.get_gl_dict({ |
Nabin Hait | 6d7b0ce | 2017-06-15 11:09:27 +0530 | [diff] [blame] | 126 | "account": warehouse_account[sle.warehouse]["account"], |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 127 | "against": expense_account, |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 128 | "cost_center": item_row.cost_center, |
Deepesh Garg | 1b30ca6 | 2020-06-19 12:12:08 +0530 | [diff] [blame] | 129 | "project": item_row.project or self.get('project'), |
xdlumertz | cdaf0a0 | 2021-11-27 12:03:35 -0300 | [diff] [blame] | 130 | "remarks": self.get("remarks") or _("Accounting Entry for Stock"), |
rohitwaghchaure | 61ad629 | 2020-01-15 16:35:31 +0530 | [diff] [blame] | 131 | "debit": flt(sle.stock_value_difference, precision), |
Nabin Hait | 8770ea2 | 2019-05-22 18:03:09 +0530 | [diff] [blame] | 132 | "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No", |
deepeshgarg007 | 3d11ac0 | 2019-05-19 00:02:01 +0530 | [diff] [blame] | 133 | }, warehouse_account[sle.warehouse]["account_currency"], item=item_row)) |
Nabin Hait | 27994c2 | 2013-08-26 16:53:30 +0530 | [diff] [blame] | 134 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 135 | gl_list.append(self.get_gl_dict({ |
Deepesh Garg | f17ea2c | 2020-12-11 21:30:39 +0530 | [diff] [blame] | 136 | "account": expense_account, |
Nabin Hait | 6d7b0ce | 2017-06-15 11:09:27 +0530 | [diff] [blame] | 137 | "against": warehouse_account[sle.warehouse]["account"], |
Nabin Hait | 8c61f34 | 2016-12-15 13:46:03 +0530 | [diff] [blame] | 138 | "cost_center": item_row.cost_center, |
xdlumertz | cdaf0a0 | 2021-11-27 12:03:35 -0300 | [diff] [blame] | 139 | "remarks": self.get("remarks") or _("Accounting Entry for Stock"), |
rohitwaghchaure | 61ad629 | 2020-01-15 16:35:31 +0530 | [diff] [blame] | 140 | "credit": flt(sle.stock_value_difference, precision), |
Nabin Hait | 3f119ec | 2019-05-16 17:28:39 +0530 | [diff] [blame] | 141 | "project": item_row.get("project") or self.get("project"), |
Nabin Hait | 8770ea2 | 2019-05-22 18:03:09 +0530 | [diff] [blame] | 142 | "is_opening": item_row.get("is_opening") or self.get("is_opening") or "No" |
deepeshgarg007 | 3d11ac0 | 2019-05-19 00:02:01 +0530 | [diff] [blame] | 143 | }, item=item_row)) |
Nabin Hait | 7a75e10 | 2013-09-17 10:21:20 +0530 | [diff] [blame] | 144 | elif sle.warehouse not in warehouse_with_no_account: |
| 145 | warehouse_with_no_account.append(sle.warehouse) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 146 | |
| 147 | if warehouse_with_no_account: |
Nabin Hait | d662502 | 2016-10-24 18:17:57 +0530 | [diff] [blame] | 148 | for wh in warehouse_with_no_account: |
| 149 | if frappe.db.get_value("Warehouse", wh, "company"): |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 150 | frappe.throw(_("Warehouse {0} is not linked to any account, please mention the account in the warehouse record or set default inventory account in company {1}.").format(wh, self.company)) |
Rushabh Mehta | 14a908b | 2015-10-15 12:28:20 +0530 | [diff] [blame] | 151 | |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 152 | return process_gl_map(gl_list, precision=precision) |
| 153 | |
| 154 | def get_debit_field_precision(self): |
| 155 | if not frappe.flags.debit_field_precision: |
| 156 | frappe.flags.debit_field_precision = frappe.get_precision("GL Entry", "debit_in_account_currency") |
| 157 | |
| 158 | return frappe.flags.debit_field_precision |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 159 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 160 | def get_voucher_details(self, default_expense_account, default_cost_center, sle_map): |
| 161 | if self.doctype == "Stock Reconciliation": |
Nabin Hait | 3f119ec | 2019-05-16 17:28:39 +0530 | [diff] [blame] | 162 | reconciliation_purpose = frappe.db.get_value(self.doctype, self.name, "purpose") |
| 163 | is_opening = "Yes" if reconciliation_purpose == "Opening Stock" else "No" |
| 164 | details = [] |
Nabin Hait | 34c551d | 2019-07-03 10:34:31 +0530 | [diff] [blame] | 165 | for voucher_detail_no in sle_map: |
Nabin Hait | 3f119ec | 2019-05-16 17:28:39 +0530 | [diff] [blame] | 166 | details.append(frappe._dict({ |
| 167 | "name": voucher_detail_no, |
| 168 | "expense_account": default_expense_account, |
| 169 | "cost_center": default_cost_center, |
| 170 | "is_opening": is_opening |
| 171 | })) |
| 172 | return details |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 173 | else: |
Nabin Hait | dd38a26 | 2014-12-26 13:15:21 +0530 | [diff] [blame] | 174 | details = self.get("items") |
Anand Doshi | 094610d | 2014-04-16 19:56:53 +0530 | [diff] [blame] | 175 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 176 | if default_expense_account or default_cost_center: |
| 177 | for d in details: |
| 178 | if default_expense_account and not d.get("expense_account"): |
| 179 | d.expense_account = default_expense_account |
| 180 | if default_cost_center and not d.get("cost_center"): |
| 181 | d.cost_center = default_cost_center |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 182 | |
Anand Doshi | de1a97d | 2014-04-17 11:37:46 +0530 | [diff] [blame] | 183 | return details |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 184 | |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 185 | def get_items_and_warehouses(self) -> Tuple[List[str], List[str]]: |
| 186 | """Get list of items and warehouses affected by a transaction""" |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 187 | |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 188 | if not (hasattr(self, "items") or hasattr(self, "packed_items")): |
| 189 | return [], [] |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 190 | |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 191 | item_rows = (self.get("items") or []) + (self.get("packed_items") or []) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 192 | |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 193 | items = {d.item_code for d in item_rows if d.item_code} |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 194 | |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 195 | warehouses = set() |
| 196 | for d in item_rows: |
| 197 | if d.get("warehouse"): |
| 198 | warehouses.add(d.warehouse) |
Nabin Hait | becf75d | 2014-03-27 17:18:29 +0530 | [diff] [blame] | 199 | |
Ankush Menat | e6ab8df | 2022-02-06 13:02:34 +0530 | [diff] [blame] | 200 | if self.doctype == "Stock Entry": |
| 201 | if d.get("s_warehouse"): |
| 202 | warehouses.add(d.s_warehouse) |
| 203 | if d.get("t_warehouse"): |
| 204 | warehouses.add(d.t_warehouse) |
| 205 | |
| 206 | return list(items), list(warehouses) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 207 | |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 208 | def get_stock_ledger_details(self): |
| 209 | stock_ledger = {} |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 210 | stock_ledger_entries = frappe.db.sql(""" |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 211 | select |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 212 | name, warehouse, stock_value_difference, valuation_rate, |
Rushabh Mehta | cc8b2b2 | 2017-03-31 12:44:29 +0530 | [diff] [blame] | 213 | voucher_detail_no, item_code, posting_date, posting_time, |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 214 | actual_qty, qty_after_transaction |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 215 | from |
| 216 | `tabStock Ledger Entry` |
| 217 | where |
Ankush Menat | 0ca60af | 2022-02-08 10:24:19 +0530 | [diff] [blame] | 218 | voucher_type=%s and voucher_no=%s and is_cancelled = 0 |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 219 | """, (self.doctype, self.name), as_dict=True) |
Nabin Hait | 0a6aaf4 | 2017-02-07 01:23:26 +0530 | [diff] [blame] | 220 | |
Nabin Hait | ea8fab5 | 2017-02-06 17:13:39 +0530 | [diff] [blame] | 221 | for sle in stock_ledger_entries: |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 222 | stock_ledger.setdefault(sle.voucher_detail_no, []).append(sle) |
Nabin Hait | 2e296fa | 2013-08-28 18:53:11 +0530 | [diff] [blame] | 223 | return stock_ledger |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 224 | |
Rushabh Mehta | 551406a | 2017-04-21 12:40:19 +0530 | [diff] [blame] | 225 | def make_batches(self, warehouse_field): |
Rushabh Mehta | e385b5b | 2017-04-20 15:21:01 +0530 | [diff] [blame] | 226 | '''Create batches if required. Called before submit''' |
| 227 | for d in self.items: |
Rushabh Mehta | 551406a | 2017-04-21 12:40:19 +0530 | [diff] [blame] | 228 | if d.get(warehouse_field) and not d.batch_no: |
| 229 | has_batch_no, create_new_batch = frappe.db.get_value('Item', d.item_code, ['has_batch_no', 'create_new_batch']) |
| 230 | if has_batch_no and create_new_batch: |
| 231 | d.batch_no = frappe.get_doc(dict( |
| 232 | doctype='Batch', |
| 233 | item=d.item_code, |
| 234 | supplier=getattr(self, 'supplier', None), |
| 235 | reference_doctype=self.doctype, |
| 236 | reference_name=self.name)).insert().name |
Rushabh Mehta | e385b5b | 2017-04-20 15:21:01 +0530 | [diff] [blame] | 237 | |
Nabin Hait | 27994c2 | 2013-08-26 16:53:30 +0530 | [diff] [blame] | 238 | def check_expense_account(self, item): |
Rushabh Mehta | 052fe82 | 2014-04-16 19:20:11 +0530 | [diff] [blame] | 239 | if not item.get("expense_account"): |
Rohit Waghchaure | ceab692 | 2020-11-18 17:57:35 +0530 | [diff] [blame] | 240 | msg = _("Please set an Expense Account in the Items table") |
| 241 | frappe.throw(_("Row #{0}: Expense Account not set for the Item {1}. {2}") |
| 242 | .format(item.idx, frappe.bold(item.item_code), msg), title=_("Expense Account Missing")) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 243 | |
Anand Doshi | 496123a | 2014-06-19 19:25:19 +0530 | [diff] [blame] | 244 | else: |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 245 | is_expense_account = frappe.get_cached_value("Account", |
Nabin Hait | 00778c9 | 2014-06-25 19:12:24 +0530 | [diff] [blame] | 246 | item.get("expense_account"), "report_type")=="Profit and Loss" |
jof2jc | 524ebbc | 2016-02-08 23:44:55 +0700 | [diff] [blame] | 247 | if self.doctype not in ("Purchase Receipt", "Purchase Invoice", "Stock Reconciliation", "Stock Entry") and not is_expense_account: |
Nabin Hait | 00778c9 | 2014-06-25 19:12:24 +0530 | [diff] [blame] | 248 | frappe.throw(_("Expense / Difference account ({0}) must be a 'Profit or Loss' account") |
| 249 | .format(item.get("expense_account"))) |
Anand Doshi | 496123a | 2014-06-19 19:25:19 +0530 | [diff] [blame] | 250 | if is_expense_account and not item.get("cost_center"): |
| 251 | frappe.throw(_("{0} {1}: Cost Center is mandatory for Item {2}").format( |
| 252 | _(self.doctype), self.name, item.get("item_code"))) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 253 | |
Rohit Waghchaure | 8996b7d | 2020-01-23 17:36:52 +0530 | [diff] [blame] | 254 | def delete_auto_created_batches(self): |
| 255 | for d in self.items: |
| 256 | if not d.batch_no: continue |
| 257 | |
Ankush Menat | ea5efd0 | 2022-01-21 13:12:31 +0530 | [diff] [blame] | 258 | frappe.db.set_value("Serial No", {"batch_no": d.batch_no, "status": "Inactive"}, "batch_no", None) |
Saqib | e9ac3e0 | 2020-03-02 15:02:58 +0530 | [diff] [blame] | 259 | |
Rohit Waghchaure | 8996b7d | 2020-01-23 17:36:52 +0530 | [diff] [blame] | 260 | d.batch_no = None |
| 261 | d.db_set("batch_no", None) |
| 262 | |
| 263 | for data in frappe.get_all("Batch", |
| 264 | {'reference_name': self.name, 'reference_doctype': self.doctype}): |
| 265 | frappe.delete_doc("Batch", data.name) |
Rohit Waghchaure | 4f4dbf1 | 2020-01-23 12:42:42 +0530 | [diff] [blame] | 266 | |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 267 | def get_sl_entries(self, d, args): |
Nabin Hait | 5288bde | 2014-11-03 15:08:21 +0530 | [diff] [blame] | 268 | sl_dict = frappe._dict({ |
Nabin Hait | 296d626 | 2014-05-02 17:36:13 +0530 | [diff] [blame] | 269 | "item_code": d.get("item_code", None), |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 270 | "warehouse": d.get("warehouse", None), |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 271 | "posting_date": self.posting_date, |
| 272 | "posting_time": self.posting_time, |
Valmik Jangla | d89dcf6 | 2016-03-04 14:33:49 +0530 | [diff] [blame] | 273 | 'fiscal_year': get_fiscal_year(self.posting_date, company=self.company)[0], |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 274 | "voucher_type": self.doctype, |
| 275 | "voucher_no": self.name, |
Nabin Hait | 1e2f20a | 2013-08-02 11:42:11 +0530 | [diff] [blame] | 276 | "voucher_detail_no": d.name, |
Nabin Hait | dc82d4f | 2014-04-07 12:02:57 +0530 | [diff] [blame] | 277 | "actual_qty": (self.docstatus==1 and 1 or -1)*flt(d.get("stock_qty")), |
Nabin Hait | c865f22 | 2015-09-21 09:18:43 +0530 | [diff] [blame] | 278 | "stock_uom": frappe.db.get_value("Item", args.get("item_code") or d.get("item_code"), "stock_uom"), |
Nabin Hait | 1e2f20a | 2013-08-02 11:42:11 +0530 | [diff] [blame] | 279 | "incoming_rate": 0, |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 280 | "company": self.company, |
Nabin Hait | 296d626 | 2014-05-02 17:36:13 +0530 | [diff] [blame] | 281 | "batch_no": cstr(d.get("batch_no")).strip(), |
| 282 | "serial_no": d.get("serial_no"), |
rohitwaghchaure | 93779c2 | 2018-03-21 17:52:41 +0530 | [diff] [blame] | 283 | "project": d.get("project") or self.get('project'), |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 284 | "is_cancelled": 1 if self.docstatus==2 else 0 |
Nabin Hait | 5288bde | 2014-11-03 15:08:21 +0530 | [diff] [blame] | 285 | }) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 286 | |
Nabin Hait | 1e2f20a | 2013-08-02 11:42:11 +0530 | [diff] [blame] | 287 | sl_dict.update(args) |
| 288 | return sl_dict |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 289 | |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 290 | def make_sl_entries(self, sl_entries, allow_negative_stock=False, |
Nabin Hait | 54c865e | 2015-03-27 15:38:31 +0530 | [diff] [blame] | 291 | via_landed_cost_voucher=False): |
Rushabh Mehta | 1f84799 | 2013-12-12 19:12:19 +0530 | [diff] [blame] | 292 | from erpnext.stock.stock_ledger import make_sl_entries |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 293 | make_sl_entries(sl_entries, allow_negative_stock, via_landed_cost_voucher) |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 294 | |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 295 | def make_gl_entries_on_cancel(self): |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 296 | if frappe.db.sql("""select name from `tabGL Entry` where voucher_type=%s |
Anand Doshi | f78d1ae | 2014-03-28 13:55:00 +0530 | [diff] [blame] | 297 | and voucher_no=%s""", (self.doctype, self.name)): |
Deepesh Garg | 2a9c5ba | 2020-04-30 10:38:58 +0530 | [diff] [blame] | 298 | self.make_gl_entries() |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 299 | |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 300 | def get_serialized_items(self): |
| 301 | serialized_items = [] |
Ankush Menat | a9c84f7 | 2021-06-11 16:00:48 +0530 | [diff] [blame] | 302 | item_codes = list(set(d.item_code for d in self.get("items"))) |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 303 | if item_codes: |
| 304 | serialized_items = frappe.db.sql_list("""select name from `tabItem` |
Rushabh Mehta | 1e8025b | 2015-07-24 15:16:25 +0530 | [diff] [blame] | 305 | where has_serial_no=1 and name in ({})""".format(", ".join(["%s"]*len(item_codes))), |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 306 | tuple(item_codes)) |
| 307 | |
| 308 | return serialized_items |
Rushabh Mehta | b16b9cd | 2015-08-03 16:13:33 +0530 | [diff] [blame] | 309 | |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 310 | def validate_warehouse(self): |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 311 | from erpnext.stock.utils import validate_disabled_warehouse, validate_warehouse_company |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 312 | |
Ankush Menat | a9c84f7 | 2021-06-11 16:00:48 +0530 | [diff] [blame] | 313 | warehouses = list(set(d.warehouse for d in |
| 314 | self.get("items") if getattr(d, "warehouse", None))) |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 315 | |
Deepesh Garg | 15ff6a5 | 2020-02-18 12:28:41 +0530 | [diff] [blame] | 316 | target_warehouses = list(set([d.target_warehouse for d in |
| 317 | self.get("items") if getattr(d, "target_warehouse", None)])) |
| 318 | |
| 319 | warehouses.extend(target_warehouses) |
| 320 | |
| 321 | from_warehouse = list(set([d.from_warehouse for d in |
| 322 | self.get("items") if getattr(d, "from_warehouse", None)])) |
| 323 | |
| 324 | warehouses.extend(from_warehouse) |
| 325 | |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 326 | for w in warehouses: |
Jannat Patel | 30c8873 | 2021-02-11 11:46:48 +0530 | [diff] [blame] | 327 | validate_disabled_warehouse(w) |
Saurabh | 2e29206 | 2015-11-18 17:03:33 +0530 | [diff] [blame] | 328 | validate_warehouse_company(w, self.company) |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 329 | |
Anand Doshi | 6b71ef5 | 2016-01-06 16:32:06 +0530 | [diff] [blame] | 330 | def update_billing_percentage(self, update_modified=True): |
marination | d6596a1 | 2020-11-02 15:07:48 +0530 | [diff] [blame] | 331 | target_ref_field = "amount" |
| 332 | if self.doctype == "Delivery Note": |
| 333 | target_ref_field = "amount - (returned_qty * rate)" |
| 334 | |
Nabin Hait | bdab0ee | 2015-12-30 19:08:11 +0530 | [diff] [blame] | 335 | self._update_percent_field({ |
| 336 | "target_dt": self.doctype + " Item", |
| 337 | "target_parent_dt": self.doctype, |
| 338 | "target_parent_field": "per_billed", |
marination | d6596a1 | 2020-11-02 15:07:48 +0530 | [diff] [blame] | 339 | "target_ref_field": target_ref_field, |
Nabin Hait | bdab0ee | 2015-12-30 19:08:11 +0530 | [diff] [blame] | 340 | "target_field": "billed_amt", |
| 341 | "name": self.name, |
Anand Doshi | 6b71ef5 | 2016-01-06 16:32:06 +0530 | [diff] [blame] | 342 | }, update_modified) |
Anand Doshi | a740f75 | 2014-06-25 13:31:02 +0530 | [diff] [blame] | 343 | |
Nabin Hait | 8af429d | 2016-11-16 17:21:59 +0530 | [diff] [blame] | 344 | def validate_inspection(self): |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 345 | """Checks if quality inspection is set/ is valid for Items that require inspection.""" |
| 346 | inspection_fieldname_map = { |
| 347 | "Purchase Receipt": "inspection_required_before_purchase", |
| 348 | "Purchase Invoice": "inspection_required_before_purchase", |
| 349 | "Sales Invoice": "inspection_required_before_delivery", |
| 350 | "Delivery Note": "inspection_required_before_delivery" |
| 351 | } |
| 352 | inspection_required_fieldname = inspection_fieldname_map.get(self.doctype) |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 353 | |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 354 | # return if inspection is not required on document level |
rohitwaghchaure | 4e8fdf7 | 2018-02-22 11:03:48 +0530 | [diff] [blame] | 355 | if ((not inspection_required_fieldname and self.doctype != "Stock Entry") or |
| 356 | (self.doctype == "Stock Entry" and not self.inspection_required) or |
| 357 | (self.doctype in ["Sales Invoice", "Purchase Invoice"] and not self.update_stock)): |
Nabin Hait | 8af429d | 2016-11-16 17:21:59 +0530 | [diff] [blame] | 358 | return |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 359 | |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 360 | for row in self.get('items'): |
| 361 | qi_required = False |
| 362 | if (inspection_required_fieldname and frappe.db.get_value("Item", row.item_code, inspection_required_fieldname)): |
| 363 | qi_required = True |
| 364 | elif self.doctype == "Stock Entry" and row.t_warehouse: |
| 365 | qi_required = True # inward stock needs inspection |
Rushabh Mehta | ffd80a6 | 2017-01-16 17:23:20 +0530 | [diff] [blame] | 366 | |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 367 | if qi_required: # validate row only if inspection is required on item level |
| 368 | self.validate_qi_presence(row) |
| 369 | if self.docstatus == 1: |
| 370 | self.validate_qi_submission(row) |
| 371 | self.validate_qi_rejection(row) |
| 372 | |
| 373 | def validate_qi_presence(self, row): |
| 374 | """Check if QI is present on row level. Warn on save and stop on submit if missing.""" |
| 375 | if not row.quality_inspection: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 376 | msg = f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}" |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 377 | if self.docstatus == 1: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 378 | frappe.throw(_(msg), title=_("Inspection Required"), exc=QualityInspectionRequiredError) |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 379 | else: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 380 | frappe.msgprint(_(msg), title=_("Inspection Required"), indicator="blue") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 381 | |
| 382 | def validate_qi_submission(self, row): |
| 383 | """Check if QI is submitted on row level, during submission""" |
marination | f67f13c | 2021-07-10 18:24:24 +0530 | [diff] [blame] | 384 | action = frappe.db.get_single_value("Stock Settings", "action_if_quality_inspection_is_not_submitted") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 385 | qa_docstatus = frappe.db.get_value("Quality Inspection", row.quality_inspection, "docstatus") |
| 386 | |
| 387 | if not qa_docstatus == 1: |
| 388 | link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection) |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 389 | msg = f"Row #{row.idx}: Quality Inspection {link} is not submitted for the item: {row.item_code}" |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 390 | if action == "Stop": |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 391 | frappe.throw(_(msg), title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError) |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 392 | else: |
Marica | 9ba3fce | 2021-06-22 11:20:17 +0530 | [diff] [blame] | 393 | frappe.msgprint(_(msg), alert=True, indicator="orange") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 394 | |
| 395 | def validate_qi_rejection(self, row): |
| 396 | """Check if QI is rejected on row level, during submission""" |
marination | f67f13c | 2021-07-10 18:24:24 +0530 | [diff] [blame] | 397 | action = frappe.db.get_single_value("Stock Settings", "action_if_quality_inspection_is_rejected") |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 398 | qa_status = frappe.db.get_value("Quality Inspection", row.quality_inspection, "status") |
| 399 | |
| 400 | if qa_status == "Rejected": |
| 401 | link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection) |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 402 | msg = f"Row #{row.idx}: Quality Inspection {link} was rejected for item {row.item_code}" |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 403 | if action == "Stop": |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 404 | frappe.throw(_(msg), title=_("Inspection Rejected"), exc=QualityInspectionRejectedError) |
marination | 9ac9a4e | 2021-06-21 16:18:35 +0530 | [diff] [blame] | 405 | else: |
marination | 654e9d8 | 2021-06-21 16:51:12 +0530 | [diff] [blame] | 406 | frappe.msgprint(_(msg), alert=True, indicator="orange") |
Manas Solanki | cc90241 | 2016-11-10 19:15:11 +0530 | [diff] [blame] | 407 | |
Nabin Hait | b2d3c0f | 2018-06-14 15:54:34 +0530 | [diff] [blame] | 408 | def update_blanket_order(self): |
Nabin Hait | d1f40ad | 2018-06-14 17:09:55 +0530 | [diff] [blame] | 409 | blanket_orders = list(set([d.blanket_order for d in self.items if d.blanket_order])) |
Nabin Hait | b2d3c0f | 2018-06-14 15:54:34 +0530 | [diff] [blame] | 410 | for blanket_order in blanket_orders: |
| 411 | frappe.get_doc("Blanket Order", blanket_order).update_ordered_qty() |
Manas Solanki | e5e87f7 | 2018-05-28 20:07:08 +0530 | [diff] [blame] | 412 | |
marination | fd04e96 | 2020-04-03 15:46:48 +0530 | [diff] [blame] | 413 | def validate_customer_provided_item(self): |
| 414 | for d in self.get('items'): |
| 415 | # Customer Provided parts will have zero valuation rate |
| 416 | if frappe.db.get_value('Item', d.item_code, 'is_customer_provided_item'): |
| 417 | d.allow_zero_valuation_rate = 1 |
Anand Doshi | 2ce39cf | 2014-04-07 18:51:58 +0530 | [diff] [blame] | 418 | |
Anupam Kumar | 7e1dcf9 | 2021-02-11 20:19:30 +0530 | [diff] [blame] | 419 | def set_rate_of_stock_uom(self): |
| 420 | if self.doctype in ["Purchase Receipt", "Purchase Invoice", "Purchase Order", "Sales Invoice", "Sales Order", "Delivery Note", "Quotation"]: |
| 421 | for d in self.get("items"): |
Rohit Waghchaure | 1358443 | 2021-03-26 14:11:50 +0530 | [diff] [blame] | 422 | d.stock_uom_rate = d.rate / (d.conversion_factor or 1) |
Anupam Kumar | 7e1dcf9 | 2021-02-11 20:19:30 +0530 | [diff] [blame] | 423 | |
Deepesh Garg | b4be292 | 2021-01-28 13:09:56 +0530 | [diff] [blame] | 424 | def validate_internal_transfer(self): |
| 425 | if self.doctype in ('Sales Invoice', 'Delivery Note', 'Purchase Invoice', 'Purchase Receipt') \ |
| 426 | and self.is_internal_transfer(): |
| 427 | self.validate_in_transit_warehouses() |
| 428 | self.validate_multi_currency() |
| 429 | self.validate_packed_items() |
| 430 | |
| 431 | def validate_in_transit_warehouses(self): |
| 432 | if (self.doctype == 'Sales Invoice' and self.get('update_stock')) or self.doctype == 'Delivery Note': |
| 433 | for item in self.get('items'): |
| 434 | if not item.target_warehouse: |
| 435 | frappe.throw(_("Row {0}: Target Warehouse is mandatory for internal transfers").format(item.idx)) |
| 436 | |
| 437 | if (self.doctype == 'Purchase Invoice' and self.get('update_stock')) or self.doctype == 'Purchase Receipt': |
| 438 | for item in self.get('items'): |
| 439 | if not item.from_warehouse: |
| 440 | frappe.throw(_("Row {0}: From Warehouse is mandatory for internal transfers").format(item.idx)) |
| 441 | |
| 442 | def validate_multi_currency(self): |
| 443 | if self.currency != self.company_currency: |
| 444 | frappe.throw(_("Internal transfers can only be done in company's default currency")) |
| 445 | |
| 446 | def validate_packed_items(self): |
| 447 | if self.doctype in ('Sales Invoice', 'Delivery Note Item') and self.get('packed_items'): |
| 448 | frappe.throw(_("Packed Items cannot be transferred internally")) |
| 449 | |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 450 | def validate_putaway_capacity(self): |
| 451 | # if over receipt is attempted while 'apply putaway rule' is disabled |
| 452 | # and if rule was applied on the transaction, validate it. |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 453 | from erpnext.stock.doctype.putaway_rule.putaway_rule import get_available_putaway_capacity |
| 454 | valid_doctype = self.doctype in ("Purchase Receipt", "Stock Entry", "Purchase Invoice", |
| 455 | "Stock Reconciliation") |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 456 | |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 457 | if self.doctype == "Purchase Invoice" and self.get("update_stock") == 0: |
| 458 | valid_doctype = False |
| 459 | |
| 460 | if valid_doctype: |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 461 | rule_map = defaultdict(dict) |
| 462 | for item in self.get("items"): |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 463 | warehouse_field = "t_warehouse" if self.doctype == "Stock Entry" else "warehouse" |
| 464 | rule = frappe.db.get_value("Putaway Rule", |
| 465 | { |
| 466 | "item_code": item.get("item_code"), |
| 467 | "warehouse": item.get(warehouse_field) |
| 468 | }, |
| 469 | ["name", "disable"], as_dict=True) |
| 470 | if rule: |
| 471 | if rule.get("disabled"): continue # dont validate for disabled rule |
| 472 | |
| 473 | if self.doctype == "Stock Reconciliation": |
| 474 | stock_qty = flt(item.qty) |
| 475 | else: |
| 476 | stock_qty = flt(item.transfer_qty) if self.doctype == "Stock Entry" else flt(item.stock_qty) |
| 477 | |
| 478 | rule_name = rule.get("name") |
| 479 | if not rule_map[rule_name]: |
| 480 | rule_map[rule_name]["warehouse"] = item.get(warehouse_field) |
| 481 | rule_map[rule_name]["item"] = item.get("item_code") |
| 482 | rule_map[rule_name]["qty_put"] = 0 |
| 483 | rule_map[rule_name]["capacity"] = get_available_putaway_capacity(rule_name) |
| 484 | rule_map[rule_name]["qty_put"] += flt(stock_qty) |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 485 | |
| 486 | for rule, values in rule_map.items(): |
| 487 | if flt(values["qty_put"]) > flt(values["capacity"]): |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 488 | message = self.prepare_over_receipt_message(rule, values) |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 489 | frappe.throw(msg=message, title=_("Over Receipt")) |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 490 | |
| 491 | def prepare_over_receipt_message(self, rule, values): |
| 492 | message = _("{0} qty of Item {1} is being received into Warehouse {2} with capacity {3}.") \ |
| 493 | .format( |
| 494 | frappe.bold(values["qty_put"]), frappe.bold(values["item"]), |
| 495 | frappe.bold(values["warehouse"]), frappe.bold(values["capacity"]) |
| 496 | ) |
| 497 | message += "<br><br>" |
| 498 | rule_link = frappe.utils.get_link_to_form("Putaway Rule", rule) |
Ankush Menat | ad6a265 | 2021-04-17 16:50:02 +0530 | [diff] [blame] | 499 | message += _("Please adjust the qty or edit {0} to proceed.").format(rule_link) |
marination | 957615b | 2021-01-18 23:47:24 +0530 | [diff] [blame] | 500 | return message |
marination | fac4035 | 2020-12-07 21:35:49 +0530 | [diff] [blame] | 501 | |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 502 | def repost_future_sle_and_gle(self): |
| 503 | args = frappe._dict({ |
| 504 | "posting_date": self.posting_date, |
| 505 | "posting_time": self.posting_time, |
| 506 | "voucher_type": self.doctype, |
| 507 | "voucher_no": self.name, |
| 508 | "company": self.company |
| 509 | }) |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 510 | if future_sle_exists(args): |
Ankush Menat | 45dd46b | 2021-11-02 10:50:52 +0530 | [diff] [blame] | 511 | item_based_reposting = cint(frappe.db.get_single_value("Stock Reposting Settings", "item_based_reposting")) |
| 512 | if item_based_reposting: |
| 513 | create_item_wise_repost_entries(voucher_type=self.doctype, voucher_no=self.name) |
| 514 | else: |
| 515 | create_repost_item_valuation_entry(args) |
| 516 | |
Nabin Hait | 19f8fa5 | 2021-02-22 22:27:22 +0530 | [diff] [blame] | 517 | |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 518 | @frappe.whitelist() |
| 519 | def make_quality_inspections(doctype, docname, items): |
Rohan Bansal | a06ec03 | 2021-06-02 14:55:31 +0530 | [diff] [blame] | 520 | if isinstance(items, str): |
| 521 | items = json.loads(items) |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 522 | |
Rohan Bansal | a06ec03 | 2021-06-02 14:55:31 +0530 | [diff] [blame] | 523 | inspections = [] |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 524 | for item in items: |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 525 | if flt(item.get("sample_size")) > flt(item.get("qty")): |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 526 | frappe.throw(_("{item_name}'s Sample Size ({sample_size}) cannot be greater than the Accepted Quantity ({accepted_quantity})").format( |
| 527 | item_name=item.get("item_name"), |
| 528 | sample_size=item.get("sample_size"), |
| 529 | accepted_quantity=item.get("qty") |
| 530 | )) |
| 531 | |
| 532 | quality_inspection = frappe.get_doc({ |
| 533 | "doctype": "Quality Inspection", |
| 534 | "inspection_type": "Incoming", |
| 535 | "inspected_by": frappe.session.user, |
| 536 | "reference_type": doctype, |
| 537 | "reference_name": docname, |
| 538 | "item_code": item.get("item_code"), |
| 539 | "description": item.get("description"), |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 540 | "sample_size": flt(item.get("sample_size")), |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 541 | "item_serial_no": item.get("serial_no").split("\n")[0] if item.get("serial_no") else None, |
| 542 | "batch_no": item.get("batch_no") |
| 543 | }).insert() |
| 544 | quality_inspection.save() |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 545 | inspections.append(quality_inspection.name) |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 546 | |
Rohan Bansal | 1cdf5a0 | 2021-05-26 14:42:15 +0530 | [diff] [blame] | 547 | return inspections |
Rohan Bansal | 7f8b95e | 2021-04-14 14:12:03 +0530 | [diff] [blame] | 548 | |
Nabin Hait | b99c77b | 2020-12-25 18:12:35 +0530 | [diff] [blame] | 549 | def is_reposting_pending(): |
| 550 | return frappe.db.exists("Repost Item Valuation", |
| 551 | {'docstatus': 1, 'status': ['in', ['Queued','In Progress']]}) |
| 552 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 553 | def future_sle_exists(args, sl_entries=None): |
| 554 | key = (args.voucher_type, args.voucher_no) |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 555 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 556 | if validate_future_sle_not_exists(args, key, sl_entries): |
| 557 | return False |
| 558 | elif get_cached_data(args, key): |
| 559 | return True |
| 560 | |
| 561 | if not sl_entries: |
| 562 | sl_entries = get_sle_entries_against_voucher(args) |
| 563 | if not sl_entries: |
| 564 | return |
| 565 | |
| 566 | or_conditions = get_conditions_to_validate_future_sle(sl_entries) |
| 567 | |
| 568 | data = frappe.db.sql(""" |
| 569 | select item_code, warehouse, count(name) as total_row |
Deepesh Garg | 6f107da | 2021-10-12 20:15:55 +0530 | [diff] [blame] | 570 | from `tabStock Ledger Entry` force index (item_warehouse) |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 571 | where |
| 572 | ({}) |
| 573 | and timestamp(posting_date, posting_time) |
| 574 | >= timestamp(%(posting_date)s, %(posting_time)s) |
| 575 | and voucher_no != %(voucher_no)s |
| 576 | and is_cancelled = 0 |
| 577 | GROUP BY |
| 578 | item_code, warehouse |
| 579 | """.format(" or ".join(or_conditions)), args, as_dict=1) |
| 580 | |
| 581 | for d in data: |
| 582 | frappe.local.future_sle[key][(d.item_code, d.warehouse)] = d.total_row |
| 583 | |
| 584 | return len(data) |
| 585 | |
| 586 | def validate_future_sle_not_exists(args, key, sl_entries=None): |
| 587 | item_key = '' |
| 588 | if args.get('item_code'): |
| 589 | item_key = (args.get('item_code'), args.get('warehouse')) |
| 590 | |
| 591 | if not sl_entries and hasattr(frappe.local, 'future_sle'): |
| 592 | if (not frappe.local.future_sle.get(key) or |
| 593 | (item_key and item_key not in frappe.local.future_sle.get(key))): |
| 594 | return True |
| 595 | |
| 596 | def get_cached_data(args, key): |
| 597 | if not hasattr(frappe.local, 'future_sle'): |
| 598 | frappe.local.future_sle = {} |
| 599 | |
| 600 | if key not in frappe.local.future_sle: |
| 601 | frappe.local.future_sle[key] = frappe._dict({}) |
| 602 | |
| 603 | if args.get('item_code'): |
| 604 | item_key = (args.get('item_code'), args.get('warehouse')) |
| 605 | count = frappe.local.future_sle[key].get(item_key) |
| 606 | |
| 607 | return True if (count or count == 0) else False |
| 608 | else: |
| 609 | return frappe.local.future_sle[key] |
| 610 | |
| 611 | def get_sle_entries_against_voucher(args): |
| 612 | return frappe.get_all("Stock Ledger Entry", |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 613 | filters={"voucher_type": args.voucher_type, "voucher_no": args.voucher_no}, |
| 614 | fields=["item_code", "warehouse"], |
| 615 | order_by="creation asc") |
| 616 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 617 | def get_conditions_to_validate_future_sle(sl_entries): |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 618 | warehouse_items_map = {} |
| 619 | for entry in sl_entries: |
| 620 | if entry.warehouse not in warehouse_items_map: |
| 621 | warehouse_items_map[entry.warehouse] = set() |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 622 | |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 623 | warehouse_items_map[entry.warehouse].add(entry.item_code) |
| 624 | |
| 625 | or_conditions = [] |
| 626 | for warehouse, items in warehouse_items_map.items(): |
| 627 | or_conditions.append( |
Noah Jacob | b5a1491 | 2021-06-15 12:44:04 +0530 | [diff] [blame] | 628 | f"""warehouse = {frappe.db.escape(warehouse)} |
| 629 | and item_code in ({', '.join(frappe.db.escape(item) for item in items)})""") |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 630 | |
Rohit Waghchaure | 8520edc | 2021-06-15 10:21:44 +0530 | [diff] [blame] | 631 | return or_conditions |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 632 | |
| 633 | def create_repost_item_valuation_entry(args): |
| 634 | args = frappe._dict(args) |
| 635 | repost_entry = frappe.new_doc("Repost Item Valuation") |
| 636 | repost_entry.based_on = args.based_on |
| 637 | if not args.based_on: |
| 638 | repost_entry.based_on = 'Transaction' if args.voucher_no else "Item and Warehouse" |
| 639 | repost_entry.voucher_type = args.voucher_type |
| 640 | repost_entry.voucher_no = args.voucher_no |
| 641 | repost_entry.item_code = args.item_code |
| 642 | repost_entry.warehouse = args.warehouse |
| 643 | repost_entry.posting_date = args.posting_date |
| 644 | repost_entry.posting_time = args.posting_time |
| 645 | repost_entry.company = args.company |
| 646 | repost_entry.allow_zero_rate = args.allow_zero_rate |
| 647 | repost_entry.flags.ignore_links = True |
Ankush Menat | aa024fc | 2021-11-18 12:51:26 +0530 | [diff] [blame] | 648 | repost_entry.flags.ignore_permissions = True |
Nabin Hait | a77b8c9 | 2020-12-21 14:45:50 +0530 | [diff] [blame] | 649 | repost_entry.save() |
Sagar Vora | 868c0bf | 2021-03-27 16:10:20 +0530 | [diff] [blame] | 650 | repost_entry.submit() |
Ankush Menat | 6dc9b82 | 2021-10-28 15:53:18 +0530 | [diff] [blame] | 651 | |
| 652 | |
| 653 | def create_item_wise_repost_entries(voucher_type, voucher_no, allow_zero_rate=False): |
| 654 | """Using a voucher create repost item valuation records for all item-warehouse pairs.""" |
| 655 | |
Ankush Menat | d220e08 | 2021-10-28 17:47:00 +0530 | [diff] [blame] | 656 | stock_ledger_entries = get_items_to_be_repost(voucher_type, voucher_no) |
| 657 | |
Ankush Menat | 6dc9b82 | 2021-10-28 15:53:18 +0530 | [diff] [blame] | 658 | distinct_item_warehouses = set() |
Ankush Menat | 6dc9b82 | 2021-10-28 15:53:18 +0530 | [diff] [blame] | 659 | repost_entries = [] |
| 660 | |
| 661 | for sle in stock_ledger_entries: |
| 662 | item_wh = (sle.item_code, sle.warehouse) |
| 663 | if item_wh in distinct_item_warehouses: |
| 664 | continue |
| 665 | distinct_item_warehouses.add(item_wh) |
| 666 | |
| 667 | repost_entry = frappe.new_doc("Repost Item Valuation") |
| 668 | repost_entry.based_on = "Item and Warehouse" |
| 669 | repost_entry.voucher_type = voucher_type |
| 670 | repost_entry.voucher_no = voucher_no |
| 671 | |
| 672 | repost_entry.item_code = sle.item_code |
| 673 | repost_entry.warehouse = sle.warehouse |
| 674 | repost_entry.posting_date = sle.posting_date |
| 675 | repost_entry.posting_time = sle.posting_time |
| 676 | repost_entry.allow_zero_rate = allow_zero_rate |
| 677 | repost_entry.flags.ignore_links = True |
Ankush Menat | 0a2964d | 2021-11-24 15:55:31 +0530 | [diff] [blame] | 678 | repost_entry.flags.ignore_permissions = True |
Ankush Menat | 6dc9b82 | 2021-10-28 15:53:18 +0530 | [diff] [blame] | 679 | repost_entry.submit() |
| 680 | repost_entries.append(repost_entry) |
| 681 | |
| 682 | return repost_entries |